feat: real alert delivery channels (Slack/Discord/PagerDuty/webhook) - #6
Merged
Conversation
Backs the Alerts "Channels" tab with real per-project destinations instead of mock state: a new alert_channels table, CRUD + test-delivery endpoints, and an evaluation worker that polls alert rules every 30s and delivers firing/resolved notifications via core/notify.deliver. Also fixes anomaly detection to only alert on metric increases (a drop in error rate or p99 latency is an improvement, not an incident), and shows the active project's real name in the Alerts/Endpoints/Traces breadcrumbs instead of a hardcoded placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alert_channelstable (migration 006), CRUD + test-delivery endpoints (/v1/channels...), andcore/notify.deliverwhich POSTs to Slack/Discord/PagerDuty/generic webhooks.worker/alerts.py, an evaluation loop (every 30s) that checks each enabled alert rule against live metrics, flips firing/resolved state, writesalert_history, and delivers notifications through the configured channel.Test plan
alert_channelstable + RLS policy are createdalert_historyrowokand closes the history row