[ryuzdev]

Draft: workflow-improvement batch, slice C (test quality).

Item 7: removes the last retry (setup project retries: 1). Evidence: ~30 consecutive first-attempt setup passes across sampled CI lanes, zero retries ever fired; a retry can only rescue a pre-account-creation failure (re-registration hits USER_ALREADY_EXISTS).

Item 8: new docker/check-tests.ts static hygiene guard (run in check.yml), unit-tested by docker/check-tests.test.ts. Red on main (18 violations), green here. Every violation rewritten: e2e polls via expect.poll, stream/reconnect tests on injected clocks, abort deadlines on AbortSignal.timeout, Rust lock-waits on timeout races and scheduler yields.

No speed claims: nothing here changes lane timing.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Source mode: Auto
• Repository: ryuzcorp/noite
• Branch: test/no-retries-no-sleeps
• File: .coderabbit.yaml
• Commit: f9719d4
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: be519799-be81-49bb-b47e-a638c0559478

📥 Commits

Reviewing files that changed from the base of the PR and between ffc4a92 and f9719d4.

⛔ Files ignored due to path filters: 1

• changelog.d/test-hygiene.md is excluded by !changelog.d/**

📒 Files selected for processing: 17

• .github/workflows/check.yml
• AGENTS.md
• apps/noite/e2e/env-telemetry.spec.ts
• apps/noite/e2e/hardening.spec.ts
• apps/noite/e2e/helpers.ts
• apps/noite/e2e/mcp.spec.ts
• apps/noite/playwright.config.ts
• apps/noite/src/http/routes/stream-hub.test.ts
• apps/noite/src/http/routes/streams.test.ts
• apps/noite/src/lib/feeds.test.tsx
• apps/noite/src/pod-host/rpc-server.test.ts
• apps/runner/src/api/tests.rs
• apps/runner/src/host/supervisor.rs
• apps/runner/src/service/apps.rs
• apps/runner/src/testutil.rs
• docker/check-tests.test.ts
• docker/check-tests.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ryuzdev]

Parent: squashed and rebased onto 519ecc5, after #89. The CHANGELOG entry is now changelog.d/test-hygiene.md. In check.yml, bun test docker/ from #89 now covers the checker's unit tests, so the separate step was dropped and only bun docker/check-tests.ts stays.

In AGENTS.md I kept main's "Run bun run check … before declaring done" bullet; this branch had deleted it, and nothing in its scope called for that.

Gates: check-tests is clean on 245 files, with 51 docker tests, 588 Rust tests and 606 UI tests passing; tsc, check and actionlint are clean. I also ran this checker over the open branches #81, #83, #88 and #90: none adds a violation beyond main's 18, which this PR fixes.

The earlier multi-lane red was the runner boot EBUSY, which is being fixed separately (F1).