Repository navigation
Merge-queue-ready gates: ci-ok aggregate, security-gate review, label-proof CI - #87
Merged
Merged
Conversation
…-proof CI - ci.yml runs on pull_request (opened/synchronize/reopened) plus merge_group; labels never start or cancel CI jobs. - merge_group always runs the release suite on both lanes with no paths-filter skip, on its own concurrency group. - ci-ok aggregate job (required check): fails on any failure/cancel, accepts skipped only where the paths-filter legitimately skips. - New security-gate workflow (required check): fails PRs touching .github/security-paths.yml sensitive paths until a reviewer adds security-reviewed; new commits strip it and fail again. - New .coderabbit.yaml: no draft reviews; lockfiles, generated runner-types and changelog.d excluded. - AGENTS.md Merging section; CHANGELOG entry.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
security-sensitive
ryuzdev
added
documentation
ryuzdev
marked this pull request as ready for review
October 22, 2026 10:24
Parent review of the ci-gate slice: - security-gate read .github/security-paths.yml from the PR's own checkout, so a PR could drop its own files (and the list itself) from the list and pass. The list now comes from the base commit; a base without the list fails closed (every change counts as sensitive). persist-credentials off. The residual risk (a PR editing the gate workflow runs its own copy) is documented for the reviewer. - ci-ok accepted a skipped e2e on any PR. It now accepts skipped only when the e2e job's own condition is false (no runtime code, no e2e label); otherwise the lanes must succeed. - security-paths: add the limits admin gate, invites, the platform rate limiter and the hostile/hardening e2e proofs; fix a truncated comment.
ryuzdev
added
the
security-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for owner review (slice A1 ci-gate, items 2, 3, 10, 13).
What
ci.ymlruns onpull_request(opened/synchronize/reopened) plusmerge_group;labeled/unlabeledno longer trigger it, so labels neither start CI jobs nor cancel the running gate.merge_groupalways runs the release suite on both lanes with no paths-filter skip, on its own concurrency group (queue entries never cancel each other or a PR run).ci-okaggregate job: fails on any failure/cancel, accepts skipped only where the paths-filter legitimately skips (docs-only PRs; thechangesjob itself on non-PR events).security-gateworkflow: fails PRs touching.github/security-paths.ymlsensitive:paths until a reviewer (never the author) addssecurity-reviewed; new commits strip it and fail again. Passes by itself onmerge_group..coderabbit.yaml: no draft reviews; lockfiles, generated runner-types, changelog.d excluded. Validated locally against https://coderabbit.ai/integrations/schema.v2.json with python jsonschema.Expected CI on this PR
ci-okgreen (this PR touches no runtime-code filter paths, so e2e skips legitimately).security-gateFAILS first: this PR touches.github/**, which is sensitive. Expected — please review and applysecurity-reviewed.e2elabel add/remove on this PR starts no newcirun and cancels nothing (proven below with run ids).Validation already run
.github/workflows/.For the parent (post-merge)
ci-ok+security-gate; squash merge method; merge queue withmerge_groupruns (always release, own concurrency key, no cancel).merge_grouppath cannot run before the queue exists: on first queue entries every job runs (no paths skip), e2e is forced torelease, andci-okrequires e2e success on that event.