fix: meld builder validation for red fives and chi sequences#7
Merged
Conversation
- Include meld builder tiles in tileCounts so palette updates in real-time - Properly check red five availability (red5m/red5p/red5s counts) - Add chi sequence validation: only allow tiles that can form valid sequences - Disable invalid tiles visually in the palette during meld building - For pon/kan: after first tile, only that tile type is selectable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in the meld builder UI:
Bug 1: Red Five Duplicate Selection
Previously, when using the pon/chi/kan meld builder, users could add more than one red five (aka dora) of the same suit (e.g., 0p, 0p, 0p). The fix:
tileCountsso the palette updates in real-time as tiles are selectedred5m/red5p/red5scount keysTilePaletteto check both disabled tiles and proper counts for red fivesBug 2: Invalid Chi Meld Sequences
Previously, the chi meld builder allowed any tiles of the same suit, even non-consecutive ones (e.g., 5p5p5p or 2m4m6m). Now:
getChiAllowedTiles()function that computes valid tiles based on current selectionBonus: Pon/Kan Improvement
For pon/kan/ankan melds, after the first tile is selected, all other tile types are now disabled in the palette (previously only enforced in code, not visually).
Testing
npm run checkpasses (only pre-existing a11y warnings)npm run buildsucceeds