Conversation
- Add SuuKantsu variant to Yaku enum as a yakuman (13 han) - Add detection logic: checks for 4 kans in the hand - SuuKantsu can be achieved with open kans (valid when open) - Add yaku_name() entries in WASM and CLI - Add i18n mapping for web frontend (translations already existed) - Add comprehensive tests: - test_suu_kantsu: 4 closed kans - test_suu_kantsu_open: mixed open/closed kans - test_san_kantsu_not_suu_kantsu: verify 3 kans gives San Kantsu, not Suu Kantsu Fixes missing yakuman that was discovered during localization work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing Suu Kantsu (四槓子, Four Kans) yakuman to agari-core.
This yakuman was discovered to be missing during localization work - the translations existed but the actual yaku was never implemented!
Changes
agari-core (yaku.rs)
SuuKantsuvariant toYakuenumhan(): returns 13 (yakuman)han_open(): returnsSome(13)- valid with open kansis_yakuman(): returns truedetect_yaku_with_context(): checks for 4 kansagari-core (main.rs)
agari-wasm (lib.rs)
web (i18n)
yakuSuuKantsuTests
test_suu_kantsu: 4 closed kans → yakuman ✓test_suu_kantsu_open: mixed open/closed kans → yakuman ✓test_san_kantsu_not_suu_kantsu: 3 kans → San Kantsu (2 han), not Suu Kantsu ✓All 232 agari tests + 27 agari-wasm tests pass.