Fold the cursor range guard into the 0.2.0 changelog section - #11
Merged
Merged
Conversation
The guard landed before 0.2.0 was ever tagged, so filing it under Fixed told readers a released version was broken. None was: v0.1.0 has no Offset namespace, so no published build could reach the overflow. It is just part of how PositionalFetcher validates a cursor in 0.2.0. Also drop "exactly" from the hasPreviousPage entry, matching the docblock correction: a bare positional '0' decodes to a non-null anchor and reports true, so the flag tracks what the codec sees rather than what any one fetcher means by origin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NzT1u3EN6X7hoHiage9HxK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #10's fix is on
mainunder## [Unreleased], which sits above## [0.2.0]. Taggingv0.2.0at currentmainwould put that code inside the release while the changelog calls itunreleased — inaccurate from the moment the tag exists.
The framing was also wrong independently of the tag. Filing the overflow guard under
### Fixedtells a reader that some released version was broken. None was:
v0.1.0has noCursorWalk\Offsetnamespace, so no published build could reach the arithmetic. The bug wasintroduced and closed entirely within the unreleased 0.2.0 work.
Change
[Unreleased]back to### Planned— nothing else is pending.PositionalFetcherbullet, stated as behaviour rather thanas a repair: positional cursors are client-supplied, so a non-integer or an out-of-range one
raises
MalformedPageExceptionbefore the upstream is called.### Changedentry. It described a wording fix to a docblock that isitself new in 0.2.0, with no behaviour change — noise for anyone reading the release.
hasPreviousPageentry: it saidtrueexactly when the position is non-origin, but a bare positional
'0'decodes to a non-nullanchor and reports
true. Now "decodes to a position other than the origin", matching thedocblock.
No code changes —
CHANGELOG.mdonly.Verification
[Unreleased],[0.2.0], and the link refs[Unreleased]holds onlyPlanned;compare/v0.1.0...v0.2.0ref already in placegit log v0.1.0 --stat -- src/Offsetv0.1.0, confirming no released build could hit the overflowRollout
This unblocks the
v0.2.0release. Once merged: tagv0.2.0at the merge commit, push the tag,publish the GitHub release, and let Packagist pick it up (it currently serves
v0.1.0only).Risk: 🟢 low — documentation only, no shipped code touched.
🤖 Generated with Claude Code