fix(self-host): link Pages and Bots in the sidebar on self-hosted installs - #1105
Open
TimBroddin wants to merge 1 commit into
Open
fix(self-host): link Pages and Bots in the sidebar on self-hosted installs#1105TimBroddin wants to merge 1 commit into
TimBroddin wants to merge 1 commit into
Conversation
Both views already work when self-hosting. Their pages carry no cloud check, the bot endpoints in index.ts register unconditionally, and DisabledOverlay returns disabled=false whenever IS_CLOUD is unset. Only the sidebar links were hidden, so the pages were reachable by typing the URL and no other way.
|
@TimBroddin is attempting to deploy a commit to the goldflag's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
📝 WalkthroughWalkthroughChangesSidebar navigation availability
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TimBroddin
marked this pull request as ready for review
August 5, 2026 06:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pages and Bots views already work on self-hosted installs. Their page components have no cloud check, the bot endpoints in
index.tsregister unconditionally alongside every other analytics route, andDisabledOverlayreturnsdisabled = falsewheneverIS_CLOUDis unset. The only thing missing is the sidebar link, so today you can reach both by typing/<siteId>/pagesor/<siteId>/botsand no other way. That seemed more like an oversight than a deliberate paywall, since a paywalled feature would normally be blocked rather than merely unlinked.Only touches the two sidebar entries. Performance and the
!IS_CLOUDQuery block are untouched, so the import stays and this doesn't overlap #1104.Summary by CodeRabbit