feat(docs): preview Archivo on marketing pages - #1077
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe home layout now configures the Google Archivo font and applies its generated class to a wrapper containing the existing header, main content, and footer layout. ChangesHome layout typography
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/src/app/[locale]/(home)/layout.tsx (1)
3-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winGroup external imports before internal imports.
Move the
nextandreactimports above the@/...imports, keeping external and internal groups alphabetized.As per coding guidelines: “Group imports by external, then internal (alphabetical within groups).”
Proposed import order
+import { Archivo } from "next/font/google"; +import type { ReactNode } from "react"; import { CustomHeader } from "`@/components/CustomHeader`"; import { Footer } from "`@/components/Footer`"; -import { Archivo } from "next/font/google"; -import type { ReactNode } from "react";🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/src/app/`[locale]/(home)/layout.tsx around lines 3 - 4, Reorder the imports in the layout module so the external next/font/google and react imports appear before any internal `@/`... imports, while preserving alphabetical order within each group.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/src/app/`[locale]/(home)/layout.tsx:
- Around line 6-9: Update the Archivo configuration in the home layout to
include the CJK subsets required by the supported zh, ko, and ja locales
alongside latin, or replace it with an equivalent font stack that covers those
scripts.
---
Nitpick comments:
In `@docs/src/app/`[locale]/(home)/layout.tsx:
- Around line 3-4: Reorder the imports in the layout module so the external
next/font/google and react imports appear before any internal `@/`... imports,
while preserving alphabetical order within each group.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4be2c3d8-7d51-4191-9537-05c8524dca3e
📒 Files selected for processing (1)
docs/src/app/[locale]/(home)/layout.tsx
| const archivo = Archivo({ | ||
| subsets: ["latin"], | ||
| display: "swap", | ||
| }); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Inspect locale definitions and confirm that all supported home locales use Latin scripts.
rg -n 'supportedLocales|locales|i18n|locale' docsRepository: rybbit-io/rybbit
Length of output: 6806
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the home layout and locale definitions with line numbers.
for f in \
"docs/src/app/[locale]/(home)/layout.tsx" \
"docs/src/i18n/routing.ts" \
"docs/src/lib/i18n.ts" \
"docs/src/app/[locale]/layout.tsx" \
"docs/src/app/[locale]/layout.config.tsx"
do
echo "===== $f ====="
wc -l "$f"
cat -n "$f" | sed -n '1,220p'
echo
doneRepository: rybbit-io/rybbit
Length of output: 4778
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Look for any other font setup or locale-specific home layout behavior.
rg -n 'Archivo|font|subsets|locales:|localePrefix|home layout|layout.tsx' docs/src/app docs/src/lib docs/src/components docs/src/i18nRepository: rybbit-io/rybbit
Length of output: 50373
Include CJK subsets in the home font
docs/src/app/[locale]/(home)/layout.tsx:6-9 — the home route supports zh, ko, and ja, so subsets: ["latin"] leaves those glyphs to fallback fonts. Add the needed subsets or use a font stack that covers them.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/src/app/`[locale]/(home)/layout.tsx around lines 6 - 9, Update the
Archivo configuration in the home layout to include the CJK subsets required by
the supported zh, ko, and ja locales alongside latin, or replace it with an
equivalent font stack that covers those scripts.
1 participant
Summary by CodeRabbit