docs(business-card): add implementation and test plans for business card notes by Copilot · Pull Request #5 · rxtech-lab/rxnote

Copilot · 2026-03-03T06:04:47Z

Documentation-only plan for supporting business card notes alongside regular-text-note, plus a new add-contact action type. No implementation changes.

`docs/BUSINESS_CARD_PLAN.md`

Data model: BusinessCard struct (firstName, lastName, email, phone, company, jobTitle, website, address) stored as JSON column on notes table
New action type: AddContactAction (type: "add-contact") — any note can include a button to save contact info to the user's address book
Backend changes: Schema updates (notes.ts), Zod validation (notes.ts), preview page rendering, migration for business_card column
iOS changes: ActionEditorView add-contact form, NoteEditorView type picker + business card fields, view model updates, Contacts framework integration
File change summary: Every file requiring modification with code snippets

Example of the new action in the discriminated union:

export const ActionSchema = z.discriminatedUnion("type", [
  URLActionSchema,
  WifiActionSchema,
  AddContactActionSchema, // new
]);

`docs/BUSINESS_CARD_TEST_PLAN.md`

Unit tests: Model serialization (5), action union (5), view model behavior (7)
UI tests: CRUD flows (4), action editor (4), type picker (3), mixed actions (1)
Test data: Sample JSON payloads and accessibility identifiers table

Original prompt

Create a plan to support business card beside the regular text note. Business card can be added to contact as well. Need contact info, title, company, first name, last name, email, and so on.

Also add support for the action to add contact action. This is docs only, no actual implementation. Modify both frontend and backend. List files need to be modified and code snippets for each modification.

Create test plan for frontend as well. Docs only.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

vercel · 2026-03-03T06:04:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
rxnote	Ready	Preview, Comment	Mar 3, 2026 6:11am

Co-authored-by: sirily11 <32106111+sirily11@users.noreply.github.com>

…ssibility identifier Co-authored-by: sirily11 <32106111+sirily11@users.noreply.github.com>

Copilot

Pull request overview

Adds documentation-only planning for introducing a new business card note type and a new add-contact note action, plus an iOS-focused frontend test plan to guide future implementation work.

Changes:

Added an implementation plan covering backend schema/Zod/OpenAPI changes and iOS UI/view-model updates for business-card notes and add-contact actions.
Added an iOS frontend test plan (unit + UI) with sample payloads and proposed accessibility identifiers.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
docs/BUSINESS_CARD_PLAN.md	End-to-end implementation plan (backend + iOS) with suggested file touch points and code snippets.
docs/BUSINESS_CARD_TEST_PLAN.md	iOS unit/UI test plan, including sample API payloads and a proposed accessibility identifier list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-03T07:55:16Z

docs/BUSINESS_CARD_PLAN.md

+| `backend/app/api/v1/notes/route.ts` | No direct changes needed (Zod schemas handle validation automatically) |
+| `backend/app/api/v1/notes/[id]/route.ts` | No direct changes needed (Zod schemas handle validation automatically) |
+| `drizzle/migrations/` | New migration file for `business_card` column |
+| `backend/next.openapi.json` | Regenerated via `./scripts/openapi-generate.sh` |


In the “File Change Summary”, backend/next.openapi.json is listed as being regenerated, but it’s actually the generator configuration checked into the repo; the generated spec is backend/public/openapi.json (gitignored). Updating this row will avoid confusion about which files are expected to change in an implementation PR.

Suggested change

| `backend/next.openapi.json` | Regenerated via `./scripts/openapi-generate.sh` |

| `backend/next.openapi.json` | Update OpenAPI generator config; run `./scripts/openapi-generate.sh` to regenerate `backend/public/openapi.json` (gitignored) |

Copilot · 2026-03-03T07:55:16Z

docs/BUSINESS_CARD_TEST_PLAN.md

+| `business-card-first-name` | First name text field |
+| `business-card-last-name` | Last name text field |
+| `business-card-email` | Email text field |
+| `business-card-phone` | Phone text field |
+| `business-card-company` | Company text field |
+| `business-card-job-title` | Job title text field |
+| `business-card-website` | Website text field |
+| `business-card-address` | Address text field |
+| `action-type-add-contact` | Add Contact segment in action type picker |
+| `contact-first-name` | First name field in action editor |
+| `contact-last-name` | Last name field in action editor |


Copilot · 2026-03-03T07:55:17Z

docs/BUSINESS_CARD_PLAN.md

+            <MapPin className="h-4 w-4" />
+            {note.businessCard.address}
+          </p>
+        )}
+      </div>


In the preview page snippet, MapPin is referenced for the address row but isn’t included in the shown lucide-react import. Since the snippet is labeled “additions only” and the real file already imports MapPin, consider updating the snippet to only add the new icons (e.g., Contact, Mail, etc.) or explicitly include MapPin so the example compiles as-written.

Suggested change

<MapPin className="h-4 w-4" />

{note.businessCard.address}

</p>

)}

</div>

{note.businessCard.address}

</p>

)}

</div>

</div>

Copilot · 2026-03-03T07:55:17Z

docs/BUSINESS_CARD_PLAN.md

+### 3. Database Migration
+
+A new Drizzle migration is required to add the `business_card` column and update the `type` column constraint.
+
+```sql
+-- drizzle migration (generated via `bun run db:push` or drizzle-kit generate)
+ALTER TABLE notes ADD COLUMN business_card TEXT DEFAULT NULL;
+```
+
+> Because SQLite stores enums as plain text, no ALTER is needed for the `type` column — the enum constraint is enforced at the application layer by Drizzle/Zod.
+


The migration section says it will “update the type column constraint”, but the SQL shown only adds business_card, and a few lines later notes that no ALTER is needed for type. Suggest rewording this section to avoid implying a DB-level enum constraint change in SQLite (or show the actual change if one is intended).

Copilot · 2026-03-03T07:55:17Z

docs/BUSINESS_CARD_PLAN.md

+    .describe("Note type"),
+  note: z.string().nullable().optional().describe("Markdown note content"),
+  businessCard: BusinessCardSchema.nullable().optional()
+    .describe("Business card data (required when type is business-card)"),


The text says businessCard is “required when type is business-card”, but the proposed Zod NoteInsertSchema/NoteUpdateSchema keeps businessCard optional and doesn’t add a conditional refinement. Either add a Zod refinement to enforce businessCard presence when type === "business-card" (and optionally enforce note presence for text notes), or adjust the wording to match the actual validation behavior.

Suggested change

.describe("Business card data (required when type is business-card)"),

.describe("Business card data (used when type is business-card)"),

Copilot · 2026-03-03T07:55:17Z

docs/BUSINESS_CARD_PLAN.md

+./scripts/openapi-generate.sh      # Regenerate backend/next.openapi.json
+./scripts/ios-update-openapi.sh    # Regenerate Swift OpenAPI client types


The OpenAPI regeneration note is inaccurate: backend/next.openapi.json is the next-openapi-gen config file, while the generated spec is written to backend/public/openapi.json (per outputDir/outputFile in backend/next.openapi.json, and it’s gitignored in backend/.gitignore). Please update the command comment and/or referenced path accordingly.

Suggested change

./scripts/openapi-generate.sh # Regenerate backend/next.openapi.json

./scripts/ios-update-openapi.sh # Regenerate Swift OpenAPI client types

./scripts/openapi-generate.sh # Regenerate backend/public/openapi.json (OpenAPI spec)

./scripts/ios-update-openapi.sh # Regenerate Swift OpenAPI client types from the updated spec

Copilot · 2026-03-03T07:55:18Z

docs/BUSINESS_CARD_PLAN.md

+./scripts/openapi-generate.sh      # Regenerate backend/next.openapi.json
+./scripts/ios-update-openapi.sh    # Regenerate Swift OpenAPI client types


Minor but important: the plan suggests running ./scripts/openapi-generate.sh, but the current script in this repo contains a hard-coded absolute path (so it won’t work for other developers/CI). Consider updating the doc to instead reference cd backend && bun run openapi:generate (or fixing the script separately and keeping the doc).

Suggested change

./scripts/openapi-generate.sh # Regenerate backend/next.openapi.json

./scripts/ios-update-openapi.sh # Regenerate Swift OpenAPI client types

cd backend && bun run openapi:generate # Regenerate backend/next.openapi.json

./scripts/ios-update-openapi.sh # Regenerate Swift OpenAPI client types

sirily11 · 2026-03-03T17:32:54Z

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Initial plan

fe54f82

Copilot AI assigned Copilot and sirily11 Mar 3, 2026

Copilot started work on behalf of sirily11 March 3, 2026 06:04 View session

autopilot-project-manager bot added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 3, 2026

vercel bot deployed to Preview March 3, 2026 06:05 View deployment

Add business card support planning docs and iOS test plan

8d27cf8

Co-authored-by: sirily11 <32106111+sirily11@users.noreply.github.com>

vercel bot deployed to Preview March 3, 2026 06:10 View deployment

Address code review feedback: clarify naming conventions and add acce…

103e2d1

…ssibility identifier Co-authored-by: sirily11 <32106111+sirily11@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for business card alongside regular text notes~~ Add business card note type and add-contact action implementation plan Mar 3, 2026

vercel bot deployed to Preview March 3, 2026 06:11 View deployment

Copilot finished work on behalf of sirily11 March 3, 2026 06:11

sirily11 marked this pull request as ready for review March 3, 2026 07:47

Copilot AI review requested due to automatic review settings March 3, 2026 07:47

autopilot-project-manager bot changed the title ~~Add business card note type and add-contact action implementation plan~~ docs(business-card): add implementation and test plans for business card notes Mar 3, 2026

Copilot started reviewing on behalf of sirily11 March 3, 2026 07:48 View session

sirily11 enabled auto-merge (squash) March 3, 2026 07:54

Copilot AI reviewed Mar 3, 2026

View reviewed changes

sirily11 merged commit 5e2e6ec into main Mar 3, 2026
13 checks passed

sirily11 deleted the copilot/add-business-card-support branch March 3, 2026 08:13

sirily11 added the released label Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(business-card): add implementation and test plans for business card notes#5

docs(business-card): add implementation and test plans for business card notes#5
sirily11 merged 3 commits intomainfrom
copilot/add-business-card-support

Copilot AI commented Mar 3, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

Uh oh!

sirily11 commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	\| `backend/next.openapi.json` \| Regenerated via `./scripts/openapi-generate.sh` \|
	\| `backend/next.openapi.json` \| Update OpenAPI generator config; run `./scripts/openapi-generate.sh` to regenerate `backend/public/openapi.json` (gitignored) \|

	.describe("Business card data (required when type is business-card)"),
	.describe("Business card data (used when type is business-card)"),

		./scripts/openapi-generate.sh # Regenerate backend/next.openapi.json
		./scripts/ios-update-openapi.sh # Regenerate Swift OpenAPI client types

Conversation

Copilot AI commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

docs/BUSINESS_CARD_PLAN.md

docs/BUSINESS_CARD_TEST_PLAN.md

Uh oh!

vercel bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sirily11 commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 3, 2026 •

edited

Loading

`docs/BUSINESS_CARD_PLAN.md`

`docs/BUSINESS_CARD_TEST_PLAN.md`

vercel bot commented Mar 3, 2026 •

edited

Loading