Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the build configuration wiring so that the RxNote app target correctly picks up its .xcconfig environment files for both Debug and Release builds. Previously the target-level XCBuildConfiguration entries had no baseConfigurationReference* keys and therefore ignored Config/Debug.xcconfig and Config/Release.xcconfig, meaning environment-specific settings (API URLs, OAuth client IDs) were silently absent.
Changes:
- Wire
Config/Debug.xcconfigandConfig/Release.xcconfigto the RxNote app target's Debug and Release build configurations inproject.pbxproj. - Switch
RxNote.xcscheme'sTestActionandLaunchActionfromDebugtoReleasebuild configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
RxNote/RxNote.xcodeproj/project.pbxproj |
Adds baseConfigurationReferenceAnchor + baseConfigurationReferenceRelativePath to both the Debug and Release app-target build configs so the xcconfig files are actually applied. |
RxNote/RxNote.xcodeproj/xcshareddata/xcschemes/RxNote.xcscheme |
Changes TestAction and LaunchAction build configurations from Debug to Release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </BuildAction> | ||
| <TestAction | ||
| buildConfiguration = "Debug" | ||
| buildConfiguration = "Release" |
There was a problem hiding this comment.
Setting TestAction's buildConfiguration to "Release" is problematic because ENABLE_TESTABILITY = YES is only present in the project-level Debug build configuration (project.pbxproj line 730). The Release configuration omits this flag, which means Xcode cannot inject the test bundle into the app. This will typically cause unit tests to fail to run entirely when triggered from this scheme. The TestAction should remain on "Debug" (its prior value), or ENABLE_TESTABILITY = YES must be explicitly added to the Release project-level build settings.
| buildConfiguration = "Release" | |
| buildConfiguration = "Debug" |
| </TestAction> | ||
| <LaunchAction | ||
| buildConfiguration = "Debug" | ||
| buildConfiguration = "Release" |
There was a problem hiding this comment.
Changing LaunchAction's buildConfiguration to "Release" means that every time a developer presses Run in this scheme, the app is built with the Release configuration (production API URL, full optimizations, no debugger-friendly DWARF info). This makes day-to-day development harder: variables may be optimised away in the debugger, and the app will connect to the production backend instead of localhost:3000. The LaunchAction should stay on "Debug" unless the explicit intent is always to run a production build during development. Compare with RxNoteClips.xcscheme which keeps its LaunchAction on "Debug" (line 39 of that file).
| buildConfiguration = "Release" | |
| buildConfiguration = "Debug" |
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.