fix: release configuration by sirily11 · Pull Request #3 · rxtech-lab/rxnote

sirily11 · 2026-03-02T11:36:08Z

No description provided.

vercel · 2026-03-02T11:36:13Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
rxnote	Error		Mar 2, 2026 11:54am

Copilot

Pull request overview

This PR updates production configuration and improves theming/dark-mode behavior across the Next.js “backend” (MDX/legal pages) and the RxNote SwiftUI app (accent color + embedded web pages).

Changes:

Adjust RxNote Release API base URL and update the iOS/macOS app accent color usage in UI components.
Add Next.js theme infrastructure (ThemeProvider + theme toggle, MDX styling tweaks, dark-mode pre-paint handling) and legal-page loading UI.
Update legal MDX copy to reference “RxNote” and revise content categories.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
backend/mdx-components.tsx	Updates MDX blockquote styling and adds an `hr` component.
backend/components/theme-toggle.tsx	Adds a client-side theme toggle using `next-themes`.
backend/app/providers.tsx	Wraps app providers with `ThemeProvider`.
backend/app/layout.tsx	Adds hydration suppression and an early script/meta to reduce theme flash.
backend/app/globals.css	Adds pre-JS background/color-scheme rules based on `prefers-color-scheme`.
backend/app/(legal)/terms/page.mdx	Updates Terms copy to reference RxNote.
backend/app/(legal)/privacy/page.mdx	Updates Privacy copy and “Content” description to match RxNote.
backend/app/(legal)/loading.tsx	Adds skeleton loading UI for legal routes.
backend/app/(legal)/layout.tsx	Adds a header container (currently empty) and imports ThemeToggle.
RxNote/RxNote/Views/Settings/WebPageView.swift	Hides tab bar and injects CSS into WKWebView for dark backgrounds.
RxNote/RxNote/Views/Notes/WiFiActionButton.swift	Adds connected-state coloring and uses the new app accent color.
RxNote/RxNote/Views/Notes/NoteListView.swift	Reorders sheet/fullScreenCover modifiers and fixes indentation of list pagination `.onAppear`.
RxNote/RxNote/Views/Notes/NoteEditorView.swift	Introduces `Color.appAccent`, applies it across UI, and adjusts action row styling/behavior.
RxNote/RxNote/Config/Release.xcconfig	Updates production API host.
RxNote/RxNote/Assets.xcassets/AccentColor.colorset/Contents.json	Defines light/dark variants for the AccentColor asset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-02T11:45:27Z

RxNote/RxNote/Config/Release.xcconfig

 // API Configuration - Production
 // Update this to your production API URL
-API_BASE_URL = https:/$()/note.rxlab.app
+API_BASE_URL = https:/$()/rxnote.rxlab.app


PR title suggests this is only a release configuration fix, but this PR also introduces significant UI/theme and legal-page changes (Next.js theming, new ThemeToggle, MDX styling, SwiftUI UI tweaks). Consider updating the PR title/description or splitting into focused PRs to reduce review/rollback risk.

Copilot · 2026-03-02T11:45:27Z

backend/app/(legal)/layout.tsx

  return (
    <div className="min-h-screen bg-background">
-      <main className="mx-auto max-w-3xl px-6 py-12">{children}</main>
+      <header className="mx-auto max-w-3xl px-6 pt-6 flex justify-end"></header>


ThemeToggle is imported but never rendered, and the <header> is empty. This will likely trigger lint failures (unused import) and adds unnecessary markup. Either render <ThemeToggle /> inside the header (if intended) or remove both the import and the empty header element.

Suggested change

<header className="mx-auto max-w-3xl px-6 pt-6 flex justify-end"></header>

<header className="mx-auto max-w-3xl px-6 pt-6 flex justify-end">

<ThemeToggle />

</header>

Copilot · 2026-03-02T11:45:27Z

backend/app/globals.css

+@media (prefers-color-scheme: dark) {
+  html {
+    background-color: oklch(0.145 0 0);
+    color-scheme: dark;
+  }
+}
+@media (prefers-color-scheme: light) {
+  html {
+    background-color: oklch(1 0 0);
+    color-scheme: light;
+  }
+}
+


The prefers-color-scheme media queries set html background/color-scheme based on system theme, which can flash the wrong theme for users who explicitly chose a different theme via next-themes (e.g. user-selected light while OS is dark will still start with dark background). Consider keying this “pre-JS” styling off the presence of the .dark class (or next-themes' injected attribute) instead of prefers-color-scheme, or otherwise ensure stored theme overrides system in the initial paint.

Suggested change

@media (prefers-color-scheme: dark) {

html {

background-color: oklch(0.145 0 0);

color-scheme: dark;

}

}

@media (prefers-color-scheme: light) {

html {

background-color: oklch(1 0 0);

color-scheme: light;

}

}

html {

background-color: oklch(1 0 0);

color-scheme: light;

}

html.dark {

background-color: oklch(0.145 0 0);

color-scheme: dark;

}

Copilot · 2026-03-02T11:45:28Z

RxNote/RxNote/Views/Settings/WebPageView.swift

        WebViewRepresentable(url: page.url)
+            .toolbar(.hidden, for: .tabBar)
            .navigationTitle(page.title)
-            #if os(iOS)
-                .navigationBarTitleDisplayMode(.inline)
-            #endif
+        #if os(iOS)
+            .navigationBarTitleDisplayMode(.inline)
+        #endif
            .ignoresSafeArea(edges: .bottom)


.toolbar(.hidden, for: .tabBar) is applied unconditionally, but this file includes a macOS NSViewRepresentable branch. This modifier (and .tabBar) is iOS-specific in other parts of the codebase (e.g. NoteDetailView guards it with #if os(iOS)), so it should be similarly guarded here to avoid macOS build failures.

Copilot · 2026-03-02T11:45:28Z

RxNote/RxNote/Views/Settings/WebPageView.swift

        let url: URL
+        @Environment(\.colorScheme) private var colorScheme



@Environment(\.colorScheme) private var colorScheme is declared but not used. If it’s not needed, remove it; if it’s intended to drive the injected CSS / webview styling, wire it up so the web content follows the app’s current scheme.

Copilot · 2026-03-02T11:45:28Z

RxNote/RxNote/Views/Notes/NoteEditorView.swift

+extension Color {
+    static var appAccent: Color {
+        Color(light: Color(red: 0.506, green: 0.220, blue: 0.820),
+              dark: Color(red: 0.720, green: 0.520, blue: 0.780))
+    }
+
+    init(light: Color, dark: Color) {
+        self.init(uiColor: UIColor { traitCollection in
+            traitCollection.userInterfaceStyle == .dark
+                ? UIColor(dark)
+                : UIColor(light)
+        })
+    }


The new Color extension uses UIColor and Color(uiColor:) unconditionally. Since this file is cross-platform (the project has macOS-specific code paths), this will not compile on macOS. Wrap the UIKit-based implementation in #if os(iOS) and provide an AppKit equivalent (NSColor / Color(nsColor:)), or prefer using the existing AccentColor asset / Color.accentColor instead.

sirily11 · 2026-03-02T12:10:10Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copilot AI review requested due to automatic review settings March 2, 2026 11:36

autopilot-project-manager bot added the bug Something isn't working label Mar 2, 2026

Copilot started reviewing on behalf of sirily11 March 2, 2026 11:36 View session

vercel bot had a problem deploying to Preview March 2, 2026 11:36 Failure

Copilot AI reviewed Mar 2, 2026

View reviewed changes

fix: release configuration

ffbc3fe

sirily11 force-pushed the release branch from 62ed7ed to ffbc3fe Compare March 2, 2026 11:53

vercel bot had a problem deploying to Preview March 2, 2026 11:54 Failure

sirily11 merged commit e68c420 into main Mar 2, 2026
8 of 9 checks passed

sirily11 deleted the release branch March 2, 2026 12:09

sirily11 added the released label Mar 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: release configuration#3

fix: release configuration#3
sirily11 merged 1 commit intomainfrom
release

sirily11 commented Mar 2, 2026

Uh oh!

vercel bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Uh oh!

sirily11 commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		let url: URL
		@Environment(\.colorScheme) private var colorScheme

Conversation

sirily11 commented Mar 2, 2026

Uh oh!

vercel bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sirily11 commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Mar 2, 2026 •

edited

Loading