Conversation
Contributor
sirily11
commented
Mar 14, 2026
sirily11
commented
- Fix auto close sheet when click import button in add contact sheet
- Add crypto wallet action
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
autopilot-project-manager
bot
added
bug
There was a problem hiding this comment.
Pull request overview
Fixes contact picker dismissing parent sheets by presenting from root window, and adds a new crypto wallet action type.
Changes:
- Refactored
CNContactPickerViewControllerpresentation to avoid dismissing parent sheets - Added
CryptoWalletActionSchemaand corresponding UI (form, button, network detection) - Changed title
TextFieldto single-line with.submitLabel(.done)
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/lib/schemas/openapi-overrides.json | Added crypto-wallet to action discriminator |
| backend/lib/schemas/notes.ts | Added CryptoWalletActionSchema zod schema |
| TypeAliases.swift | Added CryptoWalletAction typealias |
| accessibility.swift | Added UI test accessibility helpers for crypto wallet |
| RxNoteNoteCrudTests.swift | Added UI tests for contact import and crypto wallet actions |
| WiFiActionButton.swift | Added timeout logic for WiFi connection and WiFiConnectionError enum |
| TextNoteEditorContent.swift | Single-line title field, crypto wallet action label/button |
| NoteEditorView.swift | Switched to .contactPicker modifier |
| CryptoWalletActionButton.swift | New crypto wallet button with copy/deep-link functionality |
| ContactPickerViewControllerRepresentable.swift | Refactored to present picker from root window |
| ActionEditorView.swift | Added crypto wallet form, validation, save/load logic |
| project.pbxproj | Added new file reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| if (32...44).contains(trimmed.count), | ||
| trimmed.allSatisfy({ $0.isLetter || $0.isNumber }), | ||
| !trimmed.contains("0"), !trimmed.contains("O"), | ||
| !trimmed.contains("I"), !trimmed.contains("l") { |
|
|
||
| // Bitcoin Cash: starts with bitcoincash: or q/p | ||
| if trimmed.lowercased().hasPrefix("bitcoincash:") || | ||
| (trimmed.hasPrefix("q") || trimmed.hasPrefix("p")) && trimmed.count == 42 { |
|
|
||
| private func autoDetectNetwork(from address: String) { | ||
| let detected = WalletNetwork.detect(from: address) | ||
| if detected != .unknown && cryptoWalletNetwork.isEmpty { |
Comment on lines
+62
to
64
| private struct AssociatedKeys { | ||
| static var coordinator = "contactPickerCoordinator" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.