fix(wall): keep navbar visible during calibration; graceful camera placeholder#40
Merged
Merged
Conversation
…aceholder The AI page's calibration takeover used position:fixed; inset:0; z-index:1000, painting over the shared navbar entirely whenever calibration was pending — so the kiosk operator couldn't navigate away from /wall/. Anchor the overlay below the navbar instead (top: var(--wall-navbar-h)), and have wall.js measure the real navbar height into --wall-navbar-h (the prior 56px fallback was ~25px short, which also mis-sized the grid height calc). Camera previews now show a "waiting for camera…" tile instead of a broken-image icon while pump-cv has no decoded frame yet (the snapshot endpoint 404s during RTSP cold start / disconnect). Applies to both the calibration wizard previews and the live wall-cam tiles. Bump wall-sw CACHE_NAME to v5 so kiosks flush the v4 precache and pick up the changed shell assets. Note: this does not fix the live broken feeds — pump-cv cannot open either RTSP source (gym-front/gym-back); that is a camera-config/credential issue in home-ops, tracked separately. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The AI page (
/wall/) header was hidden whenever calibration was pending, and the camera previews rendered as broken-image icons.Header not visible (real bug — fixed)
.wall-calibusedposition: fixed; inset: 0; z-index: 1000, painting the calibration takeover over the entire viewport — navbar included. The kiosk operator couldn't navigate away from the AI page while calibration was pending.top: var(--wall-navbar-h)) instead ofinset: 0.wall.jsnow measures the real navbar height into--wall-navbar-h(the56pxfallback was ~25px short of the actual ~81px navbar, which also subtly mis-sized the grid height calc).wall-swCACHE_NAME→v5so kiosks flush the old precached shell assets.Camera previews (UX hardening)
While pump-cv has no decoded frame yet, the snapshot endpoint 404s (cold start / RTSP disconnect), so the
<img>showed a broken-image icon. Now both the calibration wizard previews and the live wall-cam tiles show a "waiting for camera…" placeholder instead.What this does NOT fix
The live broken feeds are not a code bug. pump-cv cannot open either RTSP source — its log loops
cannot open source rtsp://user:password123@gym-front:554/...(andgym-back) every 30s. DNS, DHCP reservations, and the CiliumNetworkPolicy (TCP/554 to10.10.40.0/24) all check out, so the cause is the camera credential/config in home-ops (the rendered password ispassword123, sourced from thepump/frigate1Password items via the pump-cv ExternalSecret). Tracked separately.Test
node --checkonwall.js/wall-sw.js✓go build ./...✓🤖 Generated with Claude Code