Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/gh-page.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,18 @@ jobs:
fetch-depth: 0
path: './docs'

- uses: pnpm/action-setup@v4
with:
version: 10
- uses: actions/setup-node@v4
with:
node-version: 22.4.1
cache: npm
cache: pnpm
Comment thread
sourcery-ai[bot] marked this conversation as resolved.

- name: Install dependencies
run: npm ci
run: pnpm install
Comment on lines 38 to +39
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Lockfile integrity enforcement is looser with pnpm install than npm ci.

npm ci failed when the lockfile and package.json were out of sync. To preserve that safety with pnpm, consider pnpm install --frozen-lockfile (or --lockfile-only elsewhere) so CI fails on lockfile drift instead of updating it during the run.

Suggested change
- name: Install dependencies
run: npm ci
run: pnpm install
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Build website
run: npm run build
run: pnpm run build

- name: Deploy
uses: peaceiris/actions-gh-pages@v3
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,15 @@ jobs:
fetch-depth: 0
path: './docs'

- uses: pnpm/action-setup@v4
with:
version: 10
- uses: actions/setup-node@v4
with:
node-version: 22.4.1
cache: npm
cache: pnpm

- name: install dependencies
run: npm ci
run: pnpm install
- name: build website
run: npm run build
run: pnpm run build