Skip to content

fix: bump Android app version to 1.0.13 - #80

Merged
rusty4444 merged 1 commit into
mainfrom
fix/issue-79-version-1.0.13
Jul 25, 2026
Merged

fix: bump Android app version to 1.0.13#80
rusty4444 merged 1 commit into
mainfrom
fix/issue-79-version-1.0.13

Conversation

@rusty4444

@rusty4444 rusty4444 commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Addresses issue #79.

Summary

  • Updates pubspec.yaml from 1.0.12+112 to 1.0.13+113 so generated Android builds report the same version as the existing v1.0.13 GitHub release.
  • Adds a 1.0.13 changelog note for the version metadata correction.
  • Adds a release workflow guard that fails tag builds when the Git tag version does not match pubspec.yaml, preventing repeat mismatched APK releases.

Verification

  • flutter test -> 42 tests passed.
  • Local release-version guard check: GITHUB_REF_NAME=v1.0.13 passes, GITHUB_REF_NAME=v1.0.14 fails against pubspec.yaml version 1.0.13 as expected.

@rusty4444
rusty4444 force-pushed the fix/issue-79-version-1.0.13 branch from 43c026b to a42c292 Compare July 23, 2026 21:10
@rusty4444

Copy link
Copy Markdown
Owner Author

Hermes Agent Review

Verdict: Changes needed — not auto-merged

Reviewed PR #80 diff, metadata, and the passing GitHub check. The version/changelog bump itself is consistent, but the new release workflow guard has a blocking correctness issue.

Blocking issue

  • .github/workflows/build-apk.yml — the new Python version-parsing regex is over-escaped inside a raw string. It matches literal \s text instead of whitespace, so it fails to parse a normal pubspec line like version: 1.0.13+113 and would block valid tag release builds with pubspec.yaml is missing a version line.

Suggested fix

Use a non-over-escaped raw-string regex, e.g. r"^version:\s*([^+\s]+)", or a small YAML/pubspec parser path that extracts the version line reliably.

Reviewed by Hermes Agent daily PR automation.

@rusty4444

Copy link
Copy Markdown
Owner Author

Hermes automated PR review

Verdict: Approved by automated review

Reviewed PR metadata, diff, head versions of the changed files, and Android Gradle config. The pubspec bump from 1.0.12+112 to 1.0.13+113 is internally consistent: CHANGELOG documents 1.0.13, no stale 1.0.12+112 references were found outside changelog history, and android/app/build.gradle.kts derives versionCode/versionName from Flutter. The new tag guard is scoped to v* tag builds, compares the tag to the semantic portion of pubspec.yaml, and runs before keystore setup. CI metadata shows the visible Analyze & Test check passed. No security, style, or breaking-change blockers found; no files were modified.

Review notes

  • Non-blocking: the remote v1.0.13 tag/release already exists, so merging this PR will not by itself rebuild or replace existing release APK assets for that tag; handle any existing-release asset correction separately if needed.

Merge gate

  • 1 visible check(s) passed

— Hermes Agent daily PR automation

@rusty4444
rusty4444 merged commit ad3ddec into main Jul 25, 2026
1 check passed
@rusty4444
rusty4444 deleted the fix/issue-79-version-1.0.13 branch July 25, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant