Add functionality to resolve external weights from safetensors and the webnn-graph weights file.#12
Merged
mtavenrath merged 6 commits intomainfrom Apr 24, 2026
Merged
Conversation
mtavenrath
force-pushed
the
resolve_weights
branch
from
ee14abb to
3b9862a
Compare
Collaborator
|
Nice! besides the existing tests, would it be possible to have a safetensor sample in in |
tarekziade
reviewed
Apr 23, 2026
| fn out_of_bounds_manifest_errors() { | ||
| let temp_dir = TempDir::new().unwrap(); | ||
| let graph_path = temp_dir.path().join("model.json"); | ||
| let manifest_path = temp_dir.path().join("manifest.json"); |
Collaborator
There was a problem hiding this comment.
can you put all default filenames at the top of the module as CONSTs?
tarekziade
reviewed
Apr 23, 2026
| .and_then(|s| s.to_str()) | ||
| .unwrap_or_default(); | ||
| [ | ||
| graph_path.with_file_name("model.safetensors"), |
Collaborator
There was a problem hiding this comment.
same remark, lets collect all defaults at the top to surface our naming conventions/standards in a single spot
Contributor
Author
I have changes ready to use this function in pywebnn and rustnn. Examples will follow soon. |
mtavenrath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support to resolve weight references into inline weights from .safetensors and wenn weight files.
Since .safetensor files might contain weights in a different format than the converted webnn graph support for weight conversion. Currently only the conversion from bfloat16 to float32 is implemented.