Skip to content

Increase test coverage - #20

Merged
ctz merged 1 commit into
rustls:feat-ip-addressfrom
ereslibre:rustls-feat-ip-address
Dec 26, 2022
Merged

Increase test coverage#20
ctz merged 1 commit into
rustls:feat-ip-addressfrom
ereslibre:rustls-feat-ip-address

Conversation

@ereslibre

@ereslibre ereslibre commented Dec 26, 2022

Copy link
Copy Markdown
Contributor

I think this PR checks the "100% line diff coverage" checkbox on #5. I say "I think" because test coverage reporting varies a bit depending on the tool used.

I am running cargo llvm-cov --all-features --html to get the report. I think I didn't miss anything, but the report is not 100% accurate.

Please, let me know if I forgot anything.

@ereslibre ereslibre mentioned this pull request Dec 26, 2022
3 tasks
@djc

djc commented Dec 26, 2022

Copy link
Copy Markdown
Member

Great work!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #20 (65cdbd2) into feat-ip-address (fb85e76) will increase coverage by 3.20%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           feat-ip-address      #20      +/-   ##
===================================================
+ Coverage            82.91%   86.11%   +3.20%     
===================================================
  Files                   15       15              
  Lines                 2095     2326     +231     
===================================================
+ Hits                  1737     2003     +266     
+ Misses                 358      323      -35     
Impacted Files Coverage Δ
src/name/ip_address.rs 100.00% <100.00%> (+7.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctz
ctz merged commit 197e19c into rustls:feat-ip-address Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants