Support multi-valued distinguished names#426
Closed
dwhjames wants to merge 1 commit intorustls:mainfrom
Closed
Conversation
As `DistinguishedName` has a private internal structure, it is possible to make a backwards compatible change to support multi-valued relative distinguished names, such as for `OU`, which is the common case. Existing code that was written with the expectation of strict set semantics will continue to have the same behavior. New functions `push_multi`, `get_all` allow the extended behavior. Parsing via `from_name` previously returned an error on multi-attribute RDNs (a SET containing more than one attribute/value pair). It now accepts them by flattening each attribute into a separate entry; on round-trip they will be emitted as individual single-attribute RDNs.
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
DistinguishedNamehas a private internal structure, it is possible to make a backwards compatible change to support multi-valued relative distinguished names, such as forOU, which is the common case.Existing code that was written with the expectation of strict set semantics will continue to have the same behavior. New functions
push_multi,get_allallow the extended behavior.Parsing via
from_namepreviously returned an error on multi-attribute RDNs (a SET containing more than one attribute/value pair). It now accepts them by flattening each attribute into a separate entry; on round-trip they will be emitted as individual single-attribute RDNs.