feat: implement recursive folder deletion with task management and au…#69
Merged
feat: implement recursive folder deletion with task management and au…#69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to-refresh #67
Pull Request
Description
This PR implements recursive folder deletion logic for the object browser. Previously, deleting a folder required the frontend to manually traverse and delete each file, which was inefficient and could lead to UI freezes.
Key changes:
Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test improvements
Security fix## Testing
Unit tests added/updated
Manual testing completed: Verified that deleting a folder with multiple files correctly creates a background task, deletes all contents, and refreshes the file list automatically upon completion.
Checklist
Code follows the project's style guidelines
Self-review completed
TypeScript types are properly defined
All commit messages are in English (Conventional Commits)
All existing tests pass
No new dependencies added, or they are justified
Related Issues
Closes #67
Screenshots (if applicable)
(Please attach screenshots of the task panel showing the "Delete Folder" task and the list refreshing)
Additional Notes
The recursive deletion supports both versioned and non-versioned buckets. For versioned buckets, it correctly handles the deletion of all object versions when the "Delete All Versions" option is selected.