add new wayland cursors#17
Merged
kchibisov merged 3 commits intorust-windowing:mainfrom May 25, 2025
m4rch3n1ng:add-a-few-missing-shapes
Merged
add new wayland cursors#17kchibisov merged 3 commits intorust-windowing:mainfrom m4rch3n1ng:add-a-few-missing-shapes
kchibisov merged 3 commits intorust-windowing:mainfrom
m4rch3n1ng:add-a-few-missing-shapes
Conversation
kchibisov
reviewed
Mar 7, 2025
|
I wouldn't bet on 'move' ever having its common use case reinterpreted when all three major platforms treat it as 'all-resize' is described. It would be really nice if the CSS spec were less ambiguous and had some meaningful reference cursors. |
madsmtm
approved these changes
May 22, 2025
kchibisov
requested changes
May 23, 2025
Member
kchibisov
left a comment
kchibisov
left a comment
There was a problem hiding this comment.
We should clearly indicate in the docs that those 2 new icons are not part of the w3c spec we refer to and that they may generally not be present as is.
Contributor
Author
|
@kchibisov i added a note in the doc comments for these two icons in [f64d8c1], where else should i add them? |
kchibisov
requested changes
May 23, 2025
Member
|
Also need a CHANGELOG entry. |
Contributor
Author
done |
kchibisov
reviewed
May 23, 2025
Member
kchibisov
left a comment
kchibisov
left a comment
There was a problem hiding this comment.
I think like that is a bit clear, since those also work on X11.
kchibisov
approved these changes
May 23, 2025
This was referenced May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the new
dnd-askandall-resizeas specified in wayland/wayland-protocols!294. one concern is, that the names might not be final (especially fordnd-ask), and changing them later would be a breaking change. i think that could potentially be mitigated by adding a new enum variant and deprecating the current, but i also think that it will probably take some time (if it will even happen) for wayland to change the naming, so it should probably be fine for a while.mutter falls back to
dnd-copyanddnd-movewhile kwin falls back tocopyandmove. since this repo consistently uses thednd-less versions, i decided to fall back tocopyandmoverespectively.i don't know what description to add to those: breeze doesn't have them and the only ones i could find for the new dnd-ask icon were in the adwaita docs and from bibata who are drawing them very differently. (though bibata does some other strange decisions like having a different cursor for
dnd-copyandcopy). if you want me to i could add a description like/// Often drawn as an arrow with either a small question mark or three dots next to it, but i just left it for now.