Skip to content

uefi: Add InputEx protocol#1937

Merged
phip1611 merged 2 commits intorust-osdev:mainfrom
JarlEvanson:simple-text-input-ex
Apr 28, 2026
Merged

uefi: Add InputEx protocol#1937
phip1611 merged 2 commits intorust-osdev:mainfrom
JarlEvanson:simple-text-input-ex

Conversation

@JarlEvanson
Copy link
Copy Markdown
Contributor

@JarlEvanson JarlEvanson commented Apr 28, 2026

Adds a wrapper around EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL to uefi.

Depends on #1936

Checklist

  • Sensible git history
  • Update the changelog (if necessary)

@JarlEvanson JarlEvanson force-pushed the simple-text-input-ex branch from 6f3d45d to 1efed5b Compare April 28, 2026 02:20
Copy link
Copy Markdown
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM! You need to fix #1936 and then adapt this one.

Comment thread uefi/src/proto/console/text/input.rs Outdated
impl InputEx {
/// Resets the input device hardware.
///
/// The `extended_verification` parameter is used to request that UEFI
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add another sentence of documentation here what that extended check actually means?

Comment thread uefi/src/proto/console/text/input.rs Outdated
@JarlEvanson JarlEvanson force-pushed the simple-text-input-ex branch from 1efed5b to 41f49f2 Compare April 28, 2026 07:04
@phip1611
Copy link
Copy Markdown
Member

phip1611 commented Apr 28, 2026

Please note that for clean git history, we don't do the merge main into branch flow but prefer rebases. So please adjust your git commit history accordingly: (git rebase main)

@JarlEvanson JarlEvanson force-pushed the simple-text-input-ex branch from 209b99e to b845b0c Compare April 28, 2026 07:18
Copy link
Copy Markdown
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@phip1611 phip1611 enabled auto-merge April 28, 2026 07:21
@phip1611 phip1611 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into rust-osdev:main with commit ee42e66 Apr 28, 2026
16 checks passed
@JarlEvanson JarlEvanson deleted the simple-text-input-ex branch April 28, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants