Allow usage and borrow cleanups #1571
Merged
+66
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilgoyette
requested changes
Jan 9, 2026
tests/oper.rs
Outdated
| let a = a.map(|f| *f as f32); | ||
| let b = b.map(|f| *f as f32); | ||
| let a = a.map(|f| *f); | ||
| let b = b.map(|f| *f); |
Collaborator
There was a problem hiding this comment.
If this function is testing the dot product, those 2 lines are useless and should be removed. They are overwriting the arrays with the same arrays.
Contributor
Author
There was a problem hiding this comment.
Thanks. Good catch. Fixed.
Collaborator
|
Thanks for the cleanup. What were you using to catch all of these? Did you do it by hand? If there's a way to automate it, we should add it to the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed several duplicated
clippy::many_single_char_namesallows across files, removed a few unnecessary uses of thevec!macro for literal values, and cleaned up some redundantclone()calls where the type implementsCopy. I also elided one unnecessary lifetime annotation and removed a few cases of unnecessary borrowing. Also rancargo fmt --allfor good measure.