Shorten rust-timer's GitHub comments even more#2424
Shorten rust-timer's GitHub comments even more#2424nnethercote merged 1 commit intorust-lang:masterfrom
Conversation
|
I have some further ideas on how to continue this, like
Would such changes be welcome? |
|
Needs a rustfmt run. The word changes seem fine, it's a little shorter without losing any information. As for further changes, the table seems the best place. If the labels in the left hand column could be made to fit on a single line, that would save some vertical space. Other than that I would be careful about removing information... we need a balance between enough explanation for newcomers vs. what works for experts. It doesn't feel like we can drastically shrink it. |
eab1f75 to
c2ec63e
Compare
Meaning of the messages posted by the rust-timer bot on GitHub PR threads is preserved using shorter ways of expressing the information. Comments concerning try perf runs are mostly affected.
c2ec63e to
7c22ee9
Compare
|
Thanks for the review! I have amended the commit with rustfmt'd code.
Agreed. I will try working on this, and will open a separate PR if I succeed in saving space here. :) |
|
I think we're running into diminishing returns here, and I'm not sure if it's worth micro-optimizing further. At the end of the day it's a wall of text that new people might read, but people who see it every day will just ignore it, because they know what it says. I like the removal of "the text below" though, that's nice compression 😆 |
This is the dilemma. How to best serve both seasoned and new contributors, each with different priorities. The compression here and in the previous PR improve the SNR, I think, which benefits both user groups. But I agree we're probably nearing the limits within the current overall design. |
|
Worth merging, IMO, but I agree there is not much more juice to be squeezed here. |
This PR continues the optimization I started in #2151. (Relates to #2149.)
Mock comparison on PC, before and after
Mock comparison on mobile, before and after