Skip to content

Shorten rust-timer's GitHub comments even more#2424

Merged
nnethercote merged 1 commit intorust-lang:masterfrom
miikkas:shorter-bot-msgs
Apr 7, 2026
Merged

Shorten rust-timer's GitHub comments even more#2424
nnethercote merged 1 commit intorust-lang:masterfrom
miikkas:shorter-bot-msgs

Conversation

@miikkas
Copy link
Copy Markdown
Contributor

@miikkas miikkas commented Apr 5, 2026

This PR continues the optimization I started in #2151. (Relates to #2149.)

Mock comparison on PC, before and after

rust-timer-before rust-timer-after

Mock comparison on mobile, before and after

rust-timer-mobile-before rust-timer-mobile-after

@miikkas
Copy link
Copy Markdown
Contributor Author

miikkas commented Apr 5, 2026

I have some further ideas on how to continue this, like

  • moving some of the explanation and advice to https://perf.rust-lang.org/help.html and linking that page directly from rust-timer's GitHub comments, and
  • hacking on the tables summarizing the perf run results (possibly with abbreviations with added explanation on the help page linked above etc.)

Would such changes be welcome?

@nnethercote
Copy link
Copy Markdown
Contributor

Needs a rustfmt run.

The word changes seem fine, it's a little shorter without losing any information.

As for further changes, the table seems the best place. If the labels in the left hand column could be made to fit on a single line, that would save some vertical space. Other than that I would be careful about removing information... we need a balance between enough explanation for newcomers vs. what works for experts. It doesn't feel like we can drastically shrink it.

@miikkas miikkas force-pushed the shorter-bot-msgs branch from eab1f75 to c2ec63e Compare April 6, 2026 05:22
Meaning of the messages posted by the rust-timer bot on GitHub PR
threads is preserved using shorter ways of expressing the information.
Comments concerning try perf runs are mostly affected.
@miikkas miikkas force-pushed the shorter-bot-msgs branch from c2ec63e to 7c22ee9 Compare April 6, 2026 05:23
@miikkas
Copy link
Copy Markdown
Contributor Author

miikkas commented Apr 6, 2026

Thanks for the review! I have amended the commit with rustfmt'd code.

As for further changes, the table seems the best place. If the labels in the left hand column could be made to fit on a single line, that would save some vertical space.

Agreed. I will try working on this, and will open a separate PR if I succeed in saving space here. :)

@Kobzol
Copy link
Copy Markdown
Member

Kobzol commented Apr 7, 2026

I think we're running into diminishing returns here, and I'm not sure if it's worth micro-optimizing further. At the end of the day it's a wall of text that new people might read, but people who see it every day will just ignore it, because they know what it says.

I like the removal of "the text below" though, that's nice compression 😆

@miikkas
Copy link
Copy Markdown
Contributor Author

miikkas commented Apr 7, 2026

At the end of the day it's a wall of text that new people might read, but people who see it every day will just ignore it, because they know what it says.

This is the dilemma. How to best serve both seasoned and new contributors, each with different priorities.

The compression here and in the previous PR improve the SNR, I think, which benefits both user groups. But I agree we're probably nearing the limits within the current overall design.

@nnethercote nnethercote added this pull request to the merge queue Apr 7, 2026
@nnethercote
Copy link
Copy Markdown
Contributor

Worth merging, IMO, but I agree there is not much more juice to be squeezed here.

Merged via the queue into rust-lang:master with commit fea8bd9 Apr 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants