Clean up TyCtxt::needs_crate_hash usage and rename it to needs_hir_hash.#156092
Open
susitsm wants to merge 2 commits intorust-lang:mainfrom
Open
Clean up TyCtxt::needs_crate_hash usage and rename it to needs_hir_hash.#156092susitsm wants to merge 2 commits intorust-lang:mainfrom
TyCtxt::needs_crate_hash usage and rename it to needs_hir_hash.#156092susitsm wants to merge 2 commits intorust-lang:mainfrom
Conversation
…nabled, not when `needs_crate_hash` is true. Exactly as the comment on the `crate_hash` field of `Linker` says, that field is only used when incremental compilation is enabled. `needs_crate_hash` returns true in some other cases too.
It's easy to confuse the functionality of `needs_crate_hash` with "is the crate_hash query needed" right now. The function returns whether we need to calculate the stable hash of various hir structs.
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing
crate_hashquery usage for #155871, theneeds_crate_hashfunction turned out to be the cause of unnecessary calls to the query. Theneeds_crate_hashname is easy to mistake for the functionality of "needs the crate_hash query". This PR removes the usage ofneeds_crate_hashwhere it was not appropriate and renames the function toneeds_hir_hashwhich better reflects its functionality.