Create definitions for promoted constants.#155898
Create definitions for promoted constants.#155898cjgillot wants to merge 18 commits intorust-lang:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Create definitions for promoted constants.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (13cee97): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 24.4%, secondary 15.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 50.7%, secondary 27.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 22.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 486.76s -> 490.092s (0.68%) |
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Create definitions for promoted constants.
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
Create definitions for promoted constants.
This comment has been minimized.
This comment has been minimized.
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
|
This pull request is already queued and waiting for a try build to finish. |
This comment has been minimized.
This comment has been minimized.
Create definitions for promoted constants.
|
💔 Test for f43dad3 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Hahaha if I want the fed information to be accessible to the next execution, it needs to be stored somewhere on-disk 🤣 |
|
☔ The latest upstream changes (presumably #156078) made this pull request unmergeable. Please resolve the merge conflicts. |
View all comments
Reopening #111693
The current handling of promoted carries an
Option<Promoted>everywhere to disambiguate the normal item from the constant.This PR replaces the promoted constants by new definitions with new
DefKind::Promoted.This method allows to unify borrow-checking with the code path for inline consts.
Requires #155777 if we want decent perf