Skip to content

Rollup of 8 pull requests#155890

Merged
rust-bors[bot] merged 20 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-XcHVBe9
Apr 28, 2026
Merged

Rollup of 8 pull requests#155890
rust-bors[bot] merged 20 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-XcHVBe9

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

heiher and others added 20 commits March 27, 2026 17:15
This PR stabilizes the following target features:

- div32
- lam-bh
- lamcas
- ld-seq-sa
- scq
Linux v7.1 will have our new MSRVs: Rust 1.85.0 and `bindgen` 0.71.1.

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
…features, r=Amanieu

Partially stabilize LoongArch target features

This PR stabilizes the following target features:

- div32
- lam-bh
- lamcas
- ld-seq-sa
- scq

Docs PR: rust-lang/reference#2217

r? @Amanieu
…trochenkov

Allow trailing `self` in more contexts

Reference PR:

- rust-lang/reference#2237

As a follow-up PR to rust-lang#152996, after this PR:
1. Trailing `self` can appear in paths
2. [E0429](https://doc.rust-lang.org/stable/error_codes/E0429.html#error-code-e0429) will be no longer emitted, `use ...::self [as target];` will be equivalent to `use ...::{self [as target]};`

r? petrochenkov
…rochenkov

Change `ItemKind::Trait` to a field variant.

This changes `ItemKind::Trait` from an octuple(!!) to an enum variant with fields. Their names were chosen to match up with existing usage and minimize renaming.

I'm leaning towards renaming `ident` to `name` as well; let me know if that's desired.
…t-ice, r=TaKO8Ki

Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder

`UnsafeBinder` uses the inner layout, but the debug layout check still looked at the outer type. Check the inner type first so this does not ICE.

Tracking issue: rust-lang#130516
Closes: rust-lang#154426
…t-const-params, r=BoxyUwU

Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`

tracking issue rust-lang#154042

r? BoxyUwU
…n-note-inner-block, r=wesleywiser

Avoid misleading closure return type note

A follow up fix for rust-lang#155670, fix a missed case rust-lang#155770 (comment)

r? @wesleywiser

cc @A4-Tacks
CI: rfl: move job forward to Linux v7.1-rc1

Linux v7.1 will have our new MSRVs: Rust 1.85.0 and `bindgen` 0.71.1.

r? @lqd @Kobzol
try-job: x86_64-rust-for-linux
@rustbot label A-rust-for-linux
@bors try
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Apr 27, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 27, 2026
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Apr 27, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 27, 2026

📌 Commit 5a87e1c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Apr 27, 2026
Rollup of 8 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-2
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 27, 2026

☀️ Try build successful (CI)
Build commit: a89413a (a89413a30bf0e1247a2320976563ca79d05dd840, parent: 345a975e76de74f090c55d5b56f5f6dd41b655a2)

@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 19m 24s
Pushing b20956b to main...

@rust-bors rust-bors Bot merged commit b20956b into rust-lang:main Apr 28, 2026
13 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 28, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#154510 Partially stabilize LoongArch target features c4a6a10917021699c749275d7ed5a6a1d4135bde (link)
#154896 Fix ICE: Scalar layout for non-primitive non-enum type unsa… 7881cc835fff4f792f38384f7adf95e433196f52 (link)
#155137 Allow trailing self in more contexts b1b06b85d9122c378f557bd4825d9def99324c5b (link)
#155513 rustc_public: implement Pattern type 4569aec2cb026a1245ca0e3485ac9a7e6ffe3965 (link)
#155675 Disallow non_exhaustive structs and enums with non_exhausti… 9ac0fddb760c112099d59bcfc7178ac192171a93 (link)
#155702 Change ItemKind::Trait to a field variant. 81248274bf7302f98b58cb559a15e2d042cc8dd1 (link)
#155874 Avoid misleading closure return type note 6098b58159722550a95b5795ff651f36981dc7fb (link)
#155876 CI: rfl: move job forward to Linux v7.1-rc1 9856a46ff068c7e44f921d5e35291aa91efa4c57 (link)

previous master: 52b6e2c208

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 52b6e2c (parent) -> b20956b (this PR)

Test differences

Show 56 test diffs

Stage 1

  • [ui] tests/ui-fulldeps/rustc_public/check_fmt_macro.rs: [missing] -> ignore (ignored when the bootstrapping stage is stage1) (J1)
  • [ui] tests/ui/const-generics/min_adt_const_params/forbid-non_exhaustive-const-param-ty.rs#full: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/min_adt_const_params/forbid-non_exhaustive-const-param-ty.rs#min: [missing] -> pass (J1)
  • [ui] tests/ui/unsafe-binders/layout-invariant.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/const-generics/min_adt_const_params/forbid-non_exhaustive-const-param-ty.rs#full: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/min_adt_const_params/forbid-non_exhaustive-const-param-ty.rs#min: [missing] -> pass (J0)
  • [ui] tests/ui/unsafe-binders/layout-invariant.rs: [missing] -> pass (J0)
  • [ui] tests/ui-fulldeps/rustc_public/check_fmt_macro.rs: [missing] -> pass (J2)

Additionally, 48 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b20956b0f44f6a9e5da5098ecbc711e4105a6f1e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 3h 42m -> 2h 42m (-26.8%)
  2. dist-arm-linux-gnueabi: 1h 12m -> 1h 31m (+26.4%)
  3. x86_64-rust-for-linux: 40m 34s -> 50m 49s (+25.3%)
  4. x86_64-gnu-aux: 2h 27m -> 1h 51m (-24.7%)
  5. dist-i586-gnu-i586-i686-musl: 1h 11m -> 1h 29m (+24.6%)
  6. test-various: 2h 11m -> 1h 39m (-24.5%)
  7. dist-i686-msvc: 1h 57m -> 2h 23m (+22.2%)
  8. dist-powerpc64le-linux-gnu: 1h 18m -> 1h 34m (+19.9%)
  9. dist-sparcv9-solaris: 1h 18m -> 1h 31m (+16.1%)
  10. dist-powerpc-linux: 1h 27m -> 1h 14m (-14.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (b20956b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 6.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.9% [6.9%, 6.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 487.959s -> 489.569s (0.33%)
Artifact size: 393.44 MiB -> 393.41 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.