slice::join: borrow only once during length calc#155858
Open
ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
Open
slice::join: borrow only once during length calc#155858ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
slice::join: borrow only once during length calc#155858ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
ChrisDenton
commented
Apr 27, 2026
|
|
||
| #[test] | ||
| fn test_join_issue_80335() { | ||
| fn test_join_inconsistent_borrow_shrink() { |
Member
Author
There was a problem hiding this comment.
I also changed the names of these tests to more clearly show how they're related. Especially since putting issue numbers in test names isn't really something we like to do any more.
This ensures the length calculation will always be self-consistent even if the real length changes when we actually come to use them.
ChrisDenton
force-pushed
the
borrowed-len
branch
from
bd6fc4c to
b7424ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the length calculation will always be self-consistent even if the real length changes when we actually come to use them.
This is a follow up to #155708