fix(coroutine): split overlapping state assignments#155841
Open
MilkBlock wants to merge 5 commits intorust-lang:mainfrom
Open
fix(coroutine): split overlapping state assignments#155841MilkBlock wants to merge 5 commits intorust-lang:mainfrom
MilkBlock wants to merge 5 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
Member
|
r? saethlin (the person you selected is not a compiler reviewer) Did you check that the ICE reported still happens? I can't make the compiler hit it. |
Author
This can be reproduced by given code in issue-149748.rs //@ edition:2024
//@ compile-flags: -Zmir-enable-passes=+Inline,+ReferencePropagation -Zlint-mir
//@ check-pass
#![feature(gen_blocks)]
#![allow(unused_variables, path_statements)]
struct NonCopy(i32);
gen fn refs<'a, 'b>(x: &'a i32, y: &'b i32, z: &'b i32) -> &'b i32 {
yield y;
z;
}
gen fn moves(x: NonCopy, y: NonCopy, z: NonCopy) -> NonCopy {
yield y;
z;
}
fn main() {
let z = 3;
let mut refs_iter = refs(&1, &2, &z);
assert_eq!(refs_iter.next(), Some(&3));
let mut moves_iter = moves(NonCopy(1), NonCopy(2), NonCopy(3));
assert!(matches!(moves_iter.next(), Some(_)));
} |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @cijiugechu
Fix #149748
coroutine.rs generated self-assign stmt when crossing yield stmt, which confused the linter.
This PR inserts additional temporary variable to make linter happy.
Before Patch
After Patch