Add AcceptContext::expect_key_value#155831
Draft
scrabsha wants to merge 1 commit intorust-lang:mainfrom
Draft
Conversation
rustbot
added
A-attributes
scrabsha
commented
Apr 26, 2026
This comment has been minimized.
This comment has been minimized.
scrabsha
commented
Apr 26, 2026
scrabsha
commented
Apr 26, 2026
scrabsha
commented
Apr 26, 2026
scrabsha
commented
Apr 26, 2026
scrabsha
force-pushed
the
push-pqrumlqtlsyk
branch
from
5c6f7cf to
27cefb8
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-pqrumlqtlsyk
branch
from
27cefb8 to
1e7d852
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-pqrumlqtlsyk
branch
from
1e7d852 to
601b48d
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-pqrumlqtlsyk
branch
from
601b48d to
8cc254b
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-pqrumlqtlsyk
branch
from
8cc254b to
cf8ee27
Compare
scrabsha
force-pushed
the
push-pqrumlqtlsyk
branch
from
cf8ee27 to
c92e28d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I would like to do one more self-review, I'm not sure reading right now this is the best use of your time)
This PR adds
AcceptContext::expect_name_valuethat takes any name-value-ish node and returns what's in it (it depends on the node). It follows the same style asAcceptContext::expect_listandAcceptContext::single.As
expect_name_valuetakes care of all the error emission, this allowed to remove any call toAttributeDiagnosticContext::expected_name_valuefrom outsiderustc_attr_parsing::context. The method now private.as_name_valueis still used in places in which we want to emit our own error messages.