tests: mark migrated UI tests as check-pass by SynapLink · Pull Request #155812 · rust-lang/rust

SynapLink · 2026-04-26T08:15:35Z

Summary

Migrate a small set of UI tests left behind by the compile-pass migration from build-pass to check-pass.

These tests exercise attributes, cfg_attr, range trait type checking, and reachable-code diagnostics. None of the changed tests need codegen or linking, so check-pass matches the intended coverage and removes the stale FIXME(#62277) notes.

Validation

python x.py test tests/ui/attributes/attr-before-view-item.rs tests/ui/attributes/attr-before-view-item2.rs tests/ui/attributes/attr-mix-new.rs tests/ui/attributes/class-attributes-1.rs tests/ui/attributes/class-attributes-2.rs tests/ui/attributes/method-attributes.rs tests/ui/attributes/unrestricted-attribute-tokens.rs tests/ui/attributes/variant-attributes.rs tests/ui/conditional-compilation/cfg-attr-multi-false.rs tests/ui/conditional-compilation/cfg-attr-multi-true.rs tests/ui/range/range_traits-4.rs tests/ui/range/range_traits-5.rs tests/ui/range/range_traits-7.rs tests/ui/reachable/expr_andand.rs tests/ui/reachable/expr_oror.rs
python x.py test tidy

rustbot · 2026-04-26T08:20:55Z

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 19 candidates

Kivooeo · 2026-04-26T12:02:45Z

hello, have you verified that check-pass in those test is enough for test?

SynapLink · 2026-04-27T07:06:42Z

hello, have you verified that check-pass in those test is enough for test?

Yes. I reran the affected tests after changing them to check-pass:

python x.py test with all 15 changed UI test paths passed: 15 passed; 0 failed
python x.py test tidy also passed

I selected these tests because they only exercise frontend/type-checking or diagnostics behavior and do not depend on codegen or linking, so check-pass should preserve the intended coverage.

Kivooeo · 2026-04-27T07:18:45Z

sorry but have you used llm to make this answer?

SynapLink · 2026-04-27T07:26:18Z

sorry but have you used llm to make this answer?

Ive used llm to help look through the code and identify fixmes to investigate. i made the actual changes myself and ran tests locally
sorry for not being explicit about that earlier

petrochenkov · 2026-04-27T15:58:23Z

The tests/ui/attributes/class-attributes-*.rs tests can be removed, their original purpose (b5729bd) is lost entirely.
Other changes look correct.
@rustbot author

rustbot · 2026-04-27T15:58:28Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

SynapLink · 2026-04-27T18:43:50Z

Removed tests/ui/attributes/class-attributes-1.rs and tests/ui/attributes/class-attributes-2.rs as suggested.

The focused UI run passed: python x.py test tests/ui/attributes tests/ui/conditional-compilation/cfg-attr-multi-false.rs tests/ui/conditional-compilation/cfg-attr-multi-true.rs tests/ui/range/range_traits-4.rs tests/ui/range/range_traits-5.rs tests/ui/range/range_traits-7.rs tests/ui/reachable/expr_andand.rs tests/ui/reachable/expr_oror.rs

Tidy passed: python x.py test tidy

@rustbot ready

petrochenkov · 2026-04-27T20:42:44Z

@bors r+ rollup

rust-bors · 2026-04-27T20:42:47Z

📌 Commit d7184b7 has been approved by petrochenkov

It is now in the queue for this repository.

…rochenkov [codex] tests: mark migrated UI tests as check-pass ## Summary Migrate a small set of UI tests left behind by the `compile-pass` migration from `build-pass` to `check-pass`. These tests exercise attributes, cfg_attr, range trait type checking, and reachable-code diagnostics. None of the changed tests need codegen or linking, so `check-pass` matches the intended coverage and removes the stale `FIXME(#62277)` notes. ## Validation - `python x.py test tests/ui/attributes/attr-before-view-item.rs tests/ui/attributes/attr-before-view-item2.rs tests/ui/attributes/attr-mix-new.rs tests/ui/attributes/class-attributes-1.rs tests/ui/attributes/class-attributes-2.rs tests/ui/attributes/method-attributes.rs tests/ui/attributes/unrestricted-attribute-tokens.rs tests/ui/attributes/variant-attributes.rs tests/ui/conditional-compilation/cfg-attr-multi-false.rs tests/ui/conditional-compilation/cfg-attr-multi-true.rs tests/ui/range/range_traits-4.rs tests/ui/range/range_traits-5.rs tests/ui/range/range_traits-7.rs tests/ui/reachable/expr_andand.rs tests/ui/reachable/expr_oror.rs` - `python x.py test tidy`

rust-bors · 2026-04-28T04:11:07Z

💔 Test for 293806b failed: CI. Failed job:

auto - x86_64-mingw-2 (web logs, enhanced plaintext logs)

petrochenkov · 2026-04-28T06:22:25Z

The failure looks spurious.
@bors retry

…2277, r=petrochenkov [codex] tests: mark migrated UI tests as check-pass ## Summary Migrate a small set of UI tests left behind by the `compile-pass` migration from `build-pass` to `check-pass`. These tests exercise attributes, cfg_attr, range trait type checking, and reachable-code diagnostics. None of the changed tests need codegen or linking, so `check-pass` matches the intended coverage and removes the stale `FIXME(rust-lang#62277)` notes. ## Validation - `python x.py test tests/ui/attributes/attr-before-view-item.rs tests/ui/attributes/attr-before-view-item2.rs tests/ui/attributes/attr-mix-new.rs tests/ui/attributes/class-attributes-1.rs tests/ui/attributes/class-attributes-2.rs tests/ui/attributes/method-attributes.rs tests/ui/attributes/unrestricted-attribute-tokens.rs tests/ui/attributes/variant-attributes.rs tests/ui/conditional-compilation/cfg-attr-multi-false.rs tests/ui/conditional-compilation/cfg-attr-multi-true.rs tests/ui/range/range_traits-4.rs tests/ui/range/range_traits-5.rs tests/ui/range/range_traits-7.rs tests/ui/reachable/expr_andand.rs tests/ui/reachable/expr_oror.rs` - `python x.py test tidy`

Rollup of 9 pull requests Successful merges: - #155381 (Fix a bug in `ChunkedBitSet::subtract`) - #155847 (Don't reload length in String::push) - #155858 (`slice::join`: borrow only once during length calc) - #155879 (enable pipe tests in Miri) - #155905 (Update LLVM to 22.1.4 (again)) - #155247 ([AIX] update linker default to bcdtors) - #155812 ([codex] tests: mark migrated UI tests as check-pass) - #155854 (Rename the diagnostic item for `std::sync::mpsc::Receiver`) - #155882 (Add regression test for #101363)

Rollup merge of #155812 - SynapLink:codex/check-pass-fixme-62277, r=petrochenkov [codex] tests: mark migrated UI tests as check-pass ## Summary Migrate a small set of UI tests left behind by the `compile-pass` migration from `build-pass` to `check-pass`. These tests exercise attributes, cfg_attr, range trait type checking, and reachable-code diagnostics. None of the changed tests need codegen or linking, so `check-pass` matches the intended coverage and removes the stale `FIXME(#62277)` notes. ## Validation - `python x.py test tests/ui/attributes/attr-before-view-item.rs tests/ui/attributes/attr-before-view-item2.rs tests/ui/attributes/attr-mix-new.rs tests/ui/attributes/class-attributes-1.rs tests/ui/attributes/class-attributes-2.rs tests/ui/attributes/method-attributes.rs tests/ui/attributes/unrestricted-attribute-tokens.rs tests/ui/attributes/variant-attributes.rs tests/ui/conditional-compilation/cfg-attr-multi-false.rs tests/ui/conditional-compilation/cfg-attr-multi-true.rs tests/ui/range/range_traits-4.rs tests/ui/range/range_traits-5.rs tests/ui/range/range_traits-7.rs tests/ui/reachable/expr_andand.rs tests/ui/reachable/expr_oror.rs` - `python x.py test tidy`

tests: mark migrated UI tests as check-pass

9854d7e

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 26, 2026

SynapLink marked this pull request as ready for review April 26, 2026 08:20

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2026

rustbot assigned petrochenkov Apr 26, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 26, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2026

tests: remove obsolete class attribute tests

d7184b7

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 27, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2026

jhpratt mentioned this pull request Apr 28, 2026

Rollup of 5 pull requests #155903

Closed

This was referenced Apr 28, 2026

Rollup of 8 pull requests #155908

Closed

Rollup of 9 pull requests #155911

Merged

rust-bors Bot merged commit 5216be3 into rust-lang:main Apr 28, 2026
11 of 12 checks passed

rustbot added this to the 1.97.0 milestone Apr 28, 2026

SynapLink changed the title ~~[codex] tests: mark migrated UI tests as check-pass~~ tests: mark migrated UI tests as check-pass Apr 28, 2026

Uh oh!

Conversation

SynapLink commented Apr 26, 2026

Summary

Validation

Uh oh!

rustbot commented Apr 26, 2026

Uh oh!

Kivooeo commented Apr 26, 2026

Uh oh!

SynapLink commented Apr 27, 2026

Uh oh!

Kivooeo commented Apr 27, 2026

Uh oh!

SynapLink commented Apr 27, 2026

Uh oh!

petrochenkov commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 27, 2026

Uh oh!

SynapLink commented Apr 27, 2026

Uh oh!

petrochenkov commented Apr 27, 2026

Uh oh!

rust-bors Bot commented Apr 27, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Apr 28, 2026

Uh oh!

petrochenkov commented Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

petrochenkov commented Apr 27, 2026 •

edited

Loading