Skip to content

Change to LLVM 22 WALI target#155654

Closed
arjunr2 wants to merge 0 commit intorust-lang:mainfrom
arjunr2:main
Closed

Change to LLVM 22 WALI target#155654
arjunr2 wants to merge 0 commit intorust-lang:mainfrom
arjunr2:main

Conversation

@arjunr2
Copy link
Copy Markdown
Contributor

@arjunr2 arjunr2 commented Apr 22, 2026

Use the new wasm32-linux-muslwali target in LLVM 22 for this target

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 22, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 17 candidates

@JohnTitor
Copy link
Copy Markdown
Member

Could you describe the background or motivation? LGTM but I'm curious to know before approving.

@arjunr2
Copy link
Copy Markdown
Contributor Author

arjunr2 commented Apr 24, 2026

The WALI target for Wasm needs a slightly different ABI from WASI, and so a new LLVM target wasm32-linux-muslwali was added earlier this year. Since this is now available in the latest llvm release, I'm propagating these changes up.

Copy link
Copy Markdown
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you! @bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

📌 Commit da2ed77 has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 24, 2026
Change to LLVM 22 WALI target

Use the new `wasm32-linux-muslwali` target in LLVM 22 for this target
@arjunr2 arjunr2 closed this Apr 24, 2026
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 24, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 24, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

This pull request was unapproved due to being closed.

This PR was contained in a rollup (#155743), which was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants