Immediately feed visibility on DefId creation by oli-obk · Pull Request #155587 · rust-lang/rust

oli-obk · 2026-04-21T07:06:34Z

This system was originally introduced in #121089

This PR was enabled by refactorings in #154945, because after that, the visibility feeding happens directly after the DefId creation, so we don't need to go through the intermediate hash table anymore

Should unblock #138995

oli-obk · 2026-04-21T07:06:51Z

@bors try @rust-timer queue

Immediately feed visibility on DefId creation

rust-bors · 2026-04-21T09:15:23Z

☀️ Try build successful (CI)
Build commit: fcefa95 (fcefa955c14d8cec90668d4e4a5e210e06e20ff8, parent: 84c11900724736a2b9afac4822031d78a9ed8e86)

rust-timer · 2026-04-21T10:20:04Z

Finished benchmarking commit (fcefa95): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.3%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-1.3%	[-1.3%, -1.3%]	1

Cycles

Results (secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.9%, -2.3%]	5
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.276s -> 490.397s (0.02%)
Artifact size: 394.36 MiB -> 394.35 MiB (-0.00%)

…on into the brg

instead of entangling it with the brg logic

rustbot · 2026-04-21T20:53:00Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-04-22T12:59:02Z

@bors r+

rust-bors · 2026-04-22T12:59:05Z

📌 Commit 3070ce9 has been approved by petrochenkov

It is now in the queue for this repository.

JonathanBrouwer · 2026-04-22T17:17:24Z

@bors rollup
This can be rolled up, no perf effect

…uwer Rollup of 10 pull requests Successful merges: - #154794 (Add on_unmatch_args) - #155133 (Document precision considerations of `Duration`-float methods) - #154283 (Remove `nodes_in_current_session` field and related assertions) - #155374 (rustdoc: fix a few spots where emit isn't respected) - #155587 (Immediately feed visibility on DefId creation) - #155622 (c-variadic: `va_arg` fixes ) - #155629 (rustc_public: Add `constness` & `asyncness` in `FnDef`) - #155632 (Some metadata cleanups) - #155639 (BinOpAssign always returns unit) - #155647 (rustc-dev-guide subtree update)

Rollup merge of #155587 - oli-obk:feed-visibility-no-hash, r=petrochenkov Immediately feed visibility on DefId creation This system was originally introduced in #121089 This PR was enabled by refactorings in #154945, because after that, the visibility feeding happens directly after the `DefId` creation, so we don't need to go through the intermediate hash table anymore Should unblock #138995

…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#154794 (Add on_unmatch_args) - rust-lang/rust#155133 (Document precision considerations of `Duration`-float methods) - rust-lang/rust#154283 (Remove `nodes_in_current_session` field and related assertions) - rust-lang/rust#155374 (rustdoc: fix a few spots where emit isn't respected) - rust-lang/rust#155587 (Immediately feed visibility on DefId creation) - rust-lang/rust#155622 (c-variadic: `va_arg` fixes ) - rust-lang/rust#155629 (rustc_public: Add `constness` & `asyncness` in `FnDef`) - rust-lang/rust#155632 (Some metadata cleanups) - rust-lang/rust#155639 (BinOpAssign always returns unit) - rust-lang/rust#155647 (rustc-dev-guide subtree update)

oli-obk assigned petrochenkov Apr 21, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 21, 2026

rust-bors Bot pushed a commit that referenced this pull request Apr 21, 2026

Auto merge of #155587 - oli-obk:feed-visibility-no-hash, r=<try>

fcefa95

Immediately feed visibility on DefId creation

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 21, 2026

oli-obk marked this pull request as ready for review April 21, 2026 10:42

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 21, 2026

petrochenkov reviewed Apr 21, 2026

View reviewed changes

Comment thread compiler/rustc_resolve/src/build_reduced_graph.rs Outdated

Comment thread compiler/rustc_resolve/src/build_reduced_graph.rs Outdated

Comment thread compiler/rustc_middle/src/ty/context.rs Outdated

Comment thread compiler/rustc_middle/src/ty/context.rs Outdated

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2026

oli-obk added 5 commits April 21, 2026 22:45

Stop creating ctor def ids for unions and move the ctor def id creati…

af3e34b

…on into the brg

Move variant ctor creation into the brg

797e68f

delegation macros are never handled in the def collector

209a2a6

Handle MacCall items directly in the def collector

af03b49

instead of entangling it with the brg logic

Immediately feed visibility on DefId creation

3070ce9

oli-obk force-pushed the feed-visibility-no-hash branch from 73120b8 to 3070ce9 Compare April 21, 2026 20:52

oli-obk added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 21, 2026

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 22, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2026

JonathanBrouwer mentioned this pull request Apr 22, 2026

Rollup of 10 pull requests #155655

Merged

rust-bors Bot merged commit 5e48418 into rust-lang:main Apr 22, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Immediately feed visibility on DefId creation#155587

Immediately feed visibility on DefId creation#155587
rust-bors[bot] merged 5 commits intorust-lang:mainfrom
oli-obk:feed-visibility-no-hash

oli-obk commented Apr 21, 2026 •

edited by rustbot

Loading

Uh oh!

oli-obk commented Apr 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Apr 21, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Apr 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 21, 2026

Uh oh!

petrochenkov commented Apr 22, 2026

Uh oh!

rust-bors Bot commented Apr 22, 2026

Uh oh!

JonathanBrouwer commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

oli-obk commented Apr 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Apr 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Apr 21, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Apr 21, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 21, 2026

Uh oh!

petrochenkov commented Apr 22, 2026

Uh oh!

rust-bors Bot commented Apr 22, 2026

Uh oh!

JonathanBrouwer commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

oli-obk commented Apr 21, 2026 •

edited by rustbot

Loading