Skip to content

stabilize never type#155499

Open
WaffleLapkin wants to merge 13 commits intorust-lang:mainfrom
WaffleLapkin:stabilize-never-type
Open

stabilize never type#155499
WaffleLapkin wants to merge 13 commits intorust-lang:mainfrom
WaffleLapkin:stabilize-never-type

Conversation

@WaffleLapkin
Copy link
Copy Markdown
Member

@WaffleLapkin WaffleLapkin commented Apr 18, 2026 •
edited by traviscross
Loading

This PR:

Cat:
52270233795_5979a3174d_b

Tracking:

Stabilization plan FCP:

Lint bump:

Rust 2024 edition change:

@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 18, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 18, 2026

⚠️ Warning ⚠️

@WaffleLapkin WaffleLapkin marked this pull request as draft April 18, 2026 22:14
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2026
@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented Apr 18, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 18, 2026
@bors
Auto merge of #155499 - WaffleLapkin:stabilize-never-type, r=<try>
1c4199d 
[experiment][0] nya
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 19, 2026

☀️ Try build successful (CI)
Build commit: 1c4199d (1c4199da70f816f2239f41c55168ff75a3663718, parent: b2f1ccf524a3a4cf9c34545167cc23b659cf1cbd)

@WaffleLapkin WaffleLapkin force-pushed the stabilize-never-type branch from 3e8df8d to 02de51f Compare April 21, 2026 18:27
This was referenced Apr 21, 2026
Open
Draft
@WaffleLapkin WaffleLapkin marked this pull request as ready for review April 21, 2026 18:37
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 21, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 17 candidates

@WaffleLapkin WaffleLapkin added the I-lang-nominated Nominated for discussion during a lang team meeting. label Apr 21, 2026
@traviscross traviscross added I-lang-radar Items that are on lang's radar and will need eventual work or consideration. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Apr 21, 2026
@traviscross traviscross changed the title stabilze never type Stabilze never type Apr 21, 2026
@traviscross traviscross added T-lang Relevant to the language team needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Apr 21, 2026
@WaffleLapkin WaffleLapkin changed the title Stabilze never type stabilze never type Apr 21, 2026
@WaffleLapkin WaffleLapkin changed the title stabilze never type stabilize never type Apr 21, 2026
Nadrieril
Nadrieril reviewed Apr 21, 2026
View reviewed changes
Comment thread library/core/src/lib.rs
@traviscross traviscross removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Apr 22, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 23, 2026

☔ The latest upstream changes (presumably #155674) made this pull request unmergeable. Please resolve the merge conflicts.

@jackh726
Copy link
Copy Markdown
Member

jackh726 commented Apr 23, 2026

As a reviewer and attendee of the lang meeting yesterday:

There was some concern about the amount of breakage in the crater run for this (~3300 crates).

Some next steps:

  • @WaffleLapkin said that they would run a similar crater run, but without changing fallback on edition < 2024
    • If there is less breakage, that might be a better stabilization target
    • There may be some "common pattern" in there that we could write a targeted hack for to smooth over the breakage for now (this would be on the types team to figure out)
  • It would be good to try to get some of the crates with more dependents from the crater run to release patches for older versions that could fix a larger portion of the breakage
    • This can/should happen in parallel

Ultimately, I get the sense that we would accept this breakage if we have to, but it would be good to dot our I's and cross our T's on minimizing.

Given this, as a reviewer, marking as blocked. @WaffleLapkin let me know if there's anything you need to me to do to help move this forward.

@jackh726 jackh726 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2026
This was referenced Apr 24, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nadrieril Nadrieril Nadrieril left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jackh726 jackh726

Labels

A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@WaffleLapkin @rustbot @rust-log-analyzer @craterbot @jackh726 @Nadrieril @traviscross @TaKO8Ki