Skip to content

Tweak comment about intrinsics in cross-crate-inlinable #155136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Apr 11, 2026
Merged

Tweak comment about intrinsics in cross-crate-inlinable #155136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions compiler/rustc_mir_transform/src/cross_crate_inline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ impl<'tcx> Visitor<'tcx> for CostChecker<'_, 'tcx> {
TerminatorKind::Call { func, unwind, .. } => {
// We track calls because they make our function not a leaf (and in theory, the
// number of calls indicates how likely this function is to perturb other CGUs).
// But intrinsics don't have a body that gets assigned to a CGU, so they are
// ignored.
// But there are a handful of intrinsics such as raw_eq that should not block
// cross-crate-inlining. Adding a broad exception for all intrinsics benchmarks well
// and seems more sustainable than an ever-growing list of intrinsics to ignore.
if let Some((fn_def_id, _)) = func.const_fn_def()
&& find_attr!(tcx, fn_def_id, RustcIntrinsic)
{
Expand Down
Loading