Skip to content

[experiment] meow#154887

Closed
WaffleLapkin wants to merge 18 commits intorust-lang:mainfrom
WaffleLapkin:never-type-madness
Closed

[experiment] meow#154887
WaffleLapkin wants to merge 18 commits intorust-lang:mainfrom
WaffleLapkin:never-type-madness

Conversation

@WaffleLapkin
Copy link
Copy Markdown
Member

@WaffleLapkin WaffleLapkin commented Apr 6, 2026

meow meow meow meow meow

@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 6, 2026
@WaffleLapkin WaffleLapkin added F-never_type `#![feature(never_type)]` S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-js Area: Rustdoc's JS front-end labels Apr 6, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented Apr 7, 2026

@bors try @rust-timer queue
@craterbot check

@craterbot

This comment was marked as resolved.

Sign in to view
@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 7, 2026
@bors
Auto merge of #154887 - WaffleLapkin:never-type-madness, r=<try>
88b8a1c 
[experiment] meow
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 7, 2026
@jieyouxu jieyouxu self-assigned this Apr 7, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 7, 2026

☀️ Try build successful (CI)
Build commit: 88b8a1c (88b8a1c6e3a6f6f8a2ed6b6a9a74e0ef1862f72c, parent: 49b6ac01d6f4c3da812039ae846407a20961aa4c)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 7, 2026

Finished benchmarking commit (88b8a1c): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results (primary 5.6%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 5.6% [5.3%, 5.9%] 2
Regressions ❌
(secondary)		 3.3% [2.1%, 4.4%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.0% [-5.3%, -0.6%] 2
All ❌✅ (primary) 5.6% [5.3%, 5.9%] 2

Cycles

Results (primary 2.1%, secondary 6.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 10.4% [2.5%, 16.9%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.8% [-3.8%, -3.8%] 1
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.2%] 21
Regressions ❌
(secondary)		 0.1% [0.0%, 0.1%] 3
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.0%] 19
Improvements ✅
(secondary)		 -0.0% [-0.1%, -0.0%] 8
All ❌✅ (primary) -0.0% [-0.1%, 0.2%] 40

Bootstrap: 487.434s -> 488.943s (0.31%)
Artifact size: 395.10 MiB -> 395.07 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 7, 2026
@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented Apr 7, 2026

@craterbot check

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 7, 2026

👌 Experiment pr-154887 created and queued.
🤖 Automatically detected try build 88b8a1c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Apr 7, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 10, 2026

☔ The latest upstream changes (presumably #155056) made this pull request unmergeable. Please resolve the merge conflicts.

@jieyouxu jieyouxu mentioned this pull request Apr 12, 2026
Merged
@jieyouxu jieyouxu removed their assignment Apr 12, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 14, 2026
@jhpratt
Rollup merge of rust-lang#155195 - jieyouxu:tidy-compiler-doc-attr, r…
30d2f5a 
…=WaffleLapkin

tidy: handle `#[cfg_attr(bootstrap, doc = "...")]` in `compiler/` comments

For the unbalanced backtick check that Waffle ran into in rust-lang#154887.

This PR cherry-picks Waffle's tidy patch in that PR (and adds some explaining comments) even though I'd say this is somewhat hacky[^1]. But since the original tidy check implementation is already based on heuristics and so are likewise fuzzy, this is probably fine in practice for most cases.

[^1]: There can be false positives/negatives like having both fragments `cfg_attr` and `doc` inside a string literal, but I would expect that to be very very niche, so it's "good enough".

(I wanted to write a regression test, but this check needs some restructuring to make it more easy to test that I don't want to bundle in this PR.)

r? wafflelapkin (or bootstrap/compiler)
rust-timer added a commit that referenced this pull request Apr 14, 2026
@rust-timer
Unrolled build for #155195
1340231 
Rollup merge of #155195 - jieyouxu:tidy-compiler-doc-attr, r=WaffleLapkin

tidy: handle `#[cfg_attr(bootstrap, doc = "...")]` in `compiler/` comments

For the unbalanced backtick check that Waffle ran into in #154887.

This PR cherry-picks Waffle's tidy patch in that PR (and adds some explaining comments) even though I'd say this is somewhat hacky[^1]. But since the original tidy check implementation is already based on heuristics and so are likewise fuzzy, this is probably fine in practice for most cases.

[^1]: There can be false positives/negatives like having both fragments `cfg_attr` and `doc` inside a string literal, but I would expect that to be very very niche, so it's "good enough".

(I wanted to write a regression test, but this check needs some restructuring to make it more easy to test that I don't want to bundle in this PR.)

r? wafflelapkin (or bootstrap/compiler)
@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 16, 2026

🚧 Experiment pr-154887 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 18, 2026

🎉 Experiment pr-154887 is completed!
📊 3981 regressed and 29 fixed (883285 total)
📊 5319 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-154887/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 18, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2026
@WaffleLapkin WaffleLapkin deleted the never-type-madness branch April 18, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature A-tidy Area: The tidy tool F-never_type `#![feature(never_type)]` T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@WaffleLapkin @rust-log-analyzer @craterbot @rust-timer @jieyouxu @rustbot