Draft
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
added
S-waiting-on-author
4 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is a separated commit to be easy to reverse later.
This reverts commit 6a30319.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
☔ The latest upstream changes (presumably #154832) made this pull request unmergeable. Please resolve the merge conflicts. |
Comment on lines
+294
to
+359
| #[stable(feature = "arc_io_traits", since = "CURRENT_RUSTC_VERSION")] | ||
| #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))] | ||
| impl<R> Read for Arc<R> | ||
| where | ||
| R: Read, | ||
| for<'a> &'a R: Read, | ||
| { | ||
| fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> { | ||
| (&**self).read(buf) | ||
| } | ||
| fn read_vectored(&mut self, bufs: &mut [IoSliceMut<'_>]) -> io::Result<usize> { | ||
| (&**self).read_vectored(bufs) | ||
| } | ||
| fn read_buf(&mut self, cursor: BorrowedCursor<'_>) -> io::Result<()> { | ||
| (&**self).read_buf(cursor) | ||
| } | ||
| #[inline] | ||
| fn is_read_vectored(&self) -> bool { | ||
| (&**self).is_read_vectored() | ||
| } | ||
| fn read_to_end(&mut self, buf: &mut Vec<u8>) -> io::Result<usize> { | ||
| (&**self).read_to_end(buf) | ||
| } | ||
| fn read_to_string(&mut self, buf: &mut String) -> io::Result<usize> { | ||
| (&**self).read_to_string(buf) | ||
| } | ||
| } | ||
| #[stable(feature = "arc_io_traits", since = "CURRENT_RUSTC_VERSION")] | ||
| #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))] | ||
| impl<W> Write for Arc<W> | ||
| where | ||
| W: Write, | ||
| for<'a> &'a W: Write, | ||
| { | ||
| fn write(&mut self, buf: &[u8]) -> io::Result<usize> { | ||
| (&**self).write(buf) | ||
| } | ||
| fn write_vectored(&mut self, bufs: &[IoSlice<'_>]) -> io::Result<usize> { | ||
| (&**self).write_vectored(bufs) | ||
| } | ||
| #[inline] | ||
| fn is_write_vectored(&self) -> bool { | ||
| (&**self).is_write_vectored() | ||
| } | ||
| #[inline] | ||
| fn flush(&mut self) -> io::Result<()> { | ||
| (&**self).flush() | ||
| } | ||
| } | ||
| #[stable(feature = "arc_io_traits", since = "CURRENT_RUSTC_VERSION")] | ||
| #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))] | ||
| impl<S> Seek for Arc<S> | ||
| where | ||
| S: Seek, | ||
| for<'a> &'a S: Seek, | ||
| { | ||
| fn seek(&mut self, pos: SeekFrom) -> io::Result<u64> { | ||
| (&**self).seek(pos) | ||
| } | ||
| fn stream_len(&mut self) -> io::Result<u64> { | ||
| (&**self).stream_len() | ||
| } | ||
| fn stream_position(&mut self) -> io::Result<u64> { | ||
| (&**self).stream_position() | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
These implementations have some potential issues. See #155684 for just this problem split out into its own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #152918
Tracking issue: #154046
Special things to note:
allocdoc testsArc. Unlike Generalize io for Arc #130675, this PR restricts the implementation more to avoid bad implementations such asArc<[u8]>.Another way to do this would be to bypass orphan rule. Is it possible in
std?