Skip to content

Suggest returning a reference for unsized place from a closure#152162

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-152064-unsized-closure-return
Apr 20, 2026
Merged

Suggest returning a reference for unsized place from a closure#152162
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-152064-unsized-closure-return

Conversation

@chenyukang
Copy link
Copy Markdown
Member

@chenyukang chenyukang commented Feb 5, 2026 •
edited
Loading

Fixes #152064

There are 3 similar note:
the size for values of type str cannot be known at compilation time
for different spans, maybe need more work to remove some of them.

This PR only adds a suggestion for using a reference.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 5, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang marked this pull request as draft February 5, 2026 11:20
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2026
@chenyukang chenyukang force-pushed the yukang-fix-152064-unsized-closure-return branch from 882fe19 to cb75047 Compare February 5, 2026 11:40
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Feb 5, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@MostAwesomeDude
Copy link
Copy Markdown

MostAwesomeDude commented Feb 6, 2026

I haven't tested this, but from reading your patch, it looks like this will be very helpful to the next newbie after me. Thank you so much for picking this up!

@chenyukang chenyukang marked this pull request as ready for review March 26, 2026 07:40
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 26, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2026
@rustbot

This comment has been minimized.

Sign in to view
@chenyukang chenyukang marked this pull request as draft March 26, 2026 07:44
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2026
@chenyukang chenyukang force-pushed the yukang-fix-152064-unsized-closure-return branch from cb75047 to b4469fc Compare March 26, 2026 08:07
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-152064-unsized-closure-return branch from b4469fc to d153f44 Compare March 26, 2026 10:39
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-152064-unsized-closure-return branch from d153f44 to f34db2f Compare March 26, 2026 12:03
@chenyukang chenyukang marked this pull request as ready for review March 29, 2026 09:48
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@petrochenkov
Copy link
Copy Markdown
Contributor

petrochenkov commented Apr 7, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 7, 2026

📌 Commit f34db2f has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152162 - chenyukang:yukang-fix-152064-unsiz…
5c3699a 
…ed-closure-return, r=petrochenkov

Suggest returning a reference for unsized place from a closure

Fixes rust-lang#152064

There are 3 similar note:
`the size for values of type str cannot be known at compilation time`
for different spans, maybe need more work to remove some of them.

This PR only adds a suggestion for using a reference.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 7, 2026
Closed
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 7, 2026

@bors r-
#154952 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 7, 2026

This pull request was unapproved.

This PR was contained in a rollup (#154952), which was unapproved.

@chenyukang chenyukang force-pushed the yukang-fix-152064-unsized-closure-return branch from f34db2f to eedf870 Compare April 19, 2026 05:15
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 19, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@chenyukang
Copy link
Copy Markdown
Member Author

chenyukang commented Apr 19, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2026
@petrochenkov
Copy link
Copy Markdown
Contributor

petrochenkov commented Apr 20, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 20, 2026

📌 Commit eedf870 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 20, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152162 - chenyukang:yukang-fix-152064-unsiz…
0ef5312 
…ed-closure-return, r=petrochenkov

Suggest returning a reference for unsized place from a closure

Fixes rust-lang#152064

There are 3 similar note:
`the size for values of type str cannot be known at compilation time`
for different spans, maybe need more work to remove some of them.

This PR only adds a suggestion for using a reference.
This was referenced Apr 20, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 20, 2026
@bors
Auto merge of #155567 - JonathanBrouwer:rollup-0zpjwMk, r=JonathanBro…
66da6ca 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #155556 (`rust-analyzer` subtree update)
 - #152162 (Suggest returning a reference for unsized place from a closure)
 - #155389 (Simplify macros for target-modifier and mitigation flags)
 - #155553 (miri subtree update)
 - #153546 (tests/ui/extern: add annotations for reference rules)
 - #155475 (Make reparsed guard metavars collect tokens)
 - #155560 (Remove `AttributeLintKind` variants - part 4)
@rust-bors rust-bors Bot merged commit 515c670 into rust-lang:main Apr 20, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 20, 2026
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Apr 24, 2026
@bors
Auto merge of #155567 - JonathanBrouwer:rollup-0zpjwMk, r=JonathanBro…
52e23b1 
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#155556 (`rust-analyzer` subtree update)
 - rust-lang/rust#152162 (Suggest returning a reference for unsized place from a closure)
 - rust-lang/rust#155389 (Simplify macros for target-modifier and mitigation flags)
 - rust-lang/rust#155553 (miri subtree update)
 - rust-lang/rust#153546 (tests/ui/extern: add annotations for reference rules)
 - rust-lang/rust#155475 (Make reparsed guard metavars collect tokens)
 - rust-lang/rust#155560 (Remove `AttributeLintKind` variants - part 4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

When returning an unsized place from a closure, should suggest returning a reference to it instead

6 participants

@chenyukang @rustbot @rust-log-analyzer @MostAwesomeDude @petrochenkov @JonathanBrouwer