Remove Fuchsia from target OS list in unix.rs for sleep #151706

PiJoules · 2026-01-26T19:51:17Z

Fuchsia doesn't support clock_nanosleep so default back to using nanosleep

rustbot · 2026-01-26T19:51:22Z

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

erickt

Could you also update https://github.com/rust-lang/rust/blob/main/library/std/src/thread/functions.rs#L319 to say fuchsia is using nanosleep?

View changes since this review

erickt · 2026-01-27T00:05:26Z

library/std/src/sys/thread/unix.rs

I think we'll also need to update this code as well. However, it looks like this code has been in Rust for a couple months now, and was added in #145177. Looking through Fuchsia it seems like we've never used this API and didn't notice it was using the wrong one? I'll do a trial run of removing this function and make sure it doesn't break things for us.

I didn't realize sleep_until hasn't stabilized, so it makes sense we didn't notice this. So I think we can put fixing that off for a future PR.

Added it to this one

NM. Will save that for a future PR.

Actually I think it'd be better to remove this line now – this PR should fix all the bugs resulting from Fuchsia's lacking clock_nanosleep support. Leaving an actual working sleep_until implementation for a future PR sounds like a good idea though.

rustbot · 2026-01-27T01:23:13Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

PiJoules · 2026-01-27T01:30:46Z

Could you also update https://github.com/rust-lang/rust/blob/main/library/std/src/thread/functions.rs#L319 to say fuchsia is using nanosleep?

View changes since this review

Done

library/std/src/sys/thread/unix.rs

library/std/src/thread/functions.rs

rustbot · 2026-01-27T10:52:45Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

joboet

The #[cfg] on the generic sleep_until in sys/thread/mod.rs needs to be updated, too. And could you please squash your commits?

View changes since this review

joboet · 2026-01-27T21:16:32Z

r? joboet

PiJoules · 2026-01-27T21:31:15Z

The #[cfg] on the generic sleep_until in sys/thread/mod.rs needs to be updated, too. And could you please squash your commits?

View changes since this review

Done

joboet · 2026-01-27T21:35:40Z

library/std/src/sys/thread/mod.rs

This line also needs to be removed.

joboet · 2026-01-27T21:36:38Z

May I suggest running ./x check library/std --target aarch64-unknown-fuchsia? That way you can check your changes locally – they aren't checked in the PR CI.

library/std/src/sys/thread/unix.rs

PiJoules · 2026-01-27T22:10:48Z

May I suggest running ./x check library/std --target aarch64-unknown-fuchsia? That way you can check your changes locally – they aren't checked in the PR CI.

Thanks. I don't work on rust a lot so this was helpful.

joboet · 2026-01-28T08:46:01Z

Thanks!
@bors r+

rust-bors · 2026-01-28T08:46:04Z

📌 Commit 5dbaac1 has been approved by joboet

It is now in the queue for this repository.

…uwer Rollup of 12 pull requests Successful merges: - #150491 (resolve: Mark items under exported ambiguous imports as exported) - #150720 (Do not suggest `derive` if there is already an impl) - #150968 (compiler-builtins: Remove the no-f16-f128 feature) - #151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain") - #151660 (Bump `std`'s `backtrace`'s `rustc-demangle`) - #151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting) - #151704 (Implement `set_output_kind` for Emscripten linker) - #151706 (Remove Fuchsia from target OS list in unix.rs for sleep) - #151769 (fix undefined behavior in VecDeque::splice) - #151779 (stdarch subtree update) - #151449 ([rustdoc] Add regression test for #151411) - #151773 (clean up checks for constant promotion of integer division/remainder operations)

Rollup merge of #151706 - PiJoules:fuchsia-nanosleep, r=joboet Remove Fuchsia from target OS list in unix.rs for sleep Fuchsia doesn't support clock_nanosleep so default back to using nanosleep

…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#150491 (resolve: Mark items under exported ambiguous imports as exported) - rust-lang/rust#150720 (Do not suggest `derive` if there is already an impl) - rust-lang/rust#150968 (compiler-builtins: Remove the no-f16-f128 feature) - rust-lang/rust#151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain") - rust-lang/rust#151660 (Bump `std`'s `backtrace`'s `rustc-demangle`) - rust-lang/rust#151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting) - rust-lang/rust#151704 (Implement `set_output_kind` for Emscripten linker) - rust-lang/rust#151706 (Remove Fuchsia from target OS list in unix.rs for sleep) - rust-lang/rust#151769 (fix undefined behavior in VecDeque::splice) - rust-lang/rust#151779 (stdarch subtree update) - rust-lang/rust#151449 ([rustdoc] Add regression test for rust-lang/rust#151411) - rust-lang/rust#151773 (clean up checks for constant promotion of integer division/remainder operations)

rustbot assigned jhpratt Jan 26, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 26, 2026

JayanAXHF added the O-fuchsia Operating system: Fuchsia label Jan 26, 2026

erickt suggested changes Jan 26, 2026

View reviewed changes

erickt reviewed Jan 27, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2026

erickt reviewed Jan 27, 2026

View reviewed changes

library/std/src/sys/thread/unix.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

joboet requested changes Jan 27, 2026

View reviewed changes

library/std/src/thread/functions.rs Outdated Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2026

PiJoules requested review from erickt and joboet January 27, 2026 18:32

joboet requested changes Jan 27, 2026

View reviewed changes

rustbot assigned joboet and unassigned jhpratt Jan 27, 2026

PiJoules force-pushed the fuchsia-nanosleep branch from 6304f16 to ff0aec3 Compare January 27, 2026 21:30

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2026

PiJoules requested a review from joboet January 27, 2026 21:31

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2026

joboet reviewed Jan 27, 2026

View reviewed changes

erickt reviewed Jan 27, 2026

View reviewed changes

library/std/src/sys/thread/unix.rs Show resolved Hide resolved

Remove Fuchsia from target OS list in unix.rs for sleep

5dbaac1

PiJoules force-pushed the fuchsia-nanosleep branch from ff0aec3 to 5dbaac1 Compare January 27, 2026 22:09

PiJoules requested review from erickt and joboet January 27, 2026 22:10

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2026

erickt approved these changes Jan 28, 2026

View reviewed changes

JonathanBrouwer mentioned this pull request Jan 28, 2026

Rollup of 12 pull requests #151794

Merged

rust-bors bot merged commit b841ab2 into rust-lang:main Jan 29, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Jan 29, 2026

PiJoules deleted the fuchsia-nanosleep branch January 29, 2026 18:21

Uh oh!

Remove Fuchsia from target OS list in unix.rs for sleep #151706

Remove Fuchsia from target OS list in unix.rs for sleep #151706

Conversation

PiJoules commented Jan 26, 2026

Uh oh!

rustbot commented Jan 26, 2026

Uh oh!

erickt left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erickt Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

erickt Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

PiJoules Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

PiJoules Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

joboet Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

PiJoules Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jan 27, 2026

Uh oh!

This comment has been minimized.

PiJoules commented Jan 27, 2026

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

rustbot commented Jan 27, 2026

Uh oh!

joboet left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joboet commented Jan 27, 2026

Uh oh!

PiJoules commented Jan 27, 2026

Uh oh!

joboet Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PiJoules Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

joboet commented Jan 27, 2026

Uh oh!

Uh oh!

PiJoules commented Jan 27, 2026

Uh oh!

joboet commented Jan 28, 2026

Uh oh!

rust-bors bot commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

erickt left a comment •

edited by rustbot

Loading

joboet left a comment •

edited by rustbot

Loading

joboet Jan 27, 2026 •

edited

Loading