Skip to content

Fix wrong suggestion for returning async closure#151194

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-150701-async-closure
Apr 21, 2026
Merged

Fix wrong suggestion for returning async closure#151194
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-150701-async-closure

Conversation

@chenyukang
Copy link
Copy Markdown
Member

@chenyukang chenyukang commented Jan 16, 2026 •
edited by rustbot
Loading

Fixes #150701

r? @estebank

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2026
@SpriteOvO SpriteOvO added A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` A-async-closures `async || {}` labels Jan 16, 2026
Kivooeo
Kivooeo approved these changes Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estebank, is that fine if i reviewed it?

View changes since this review

@wesleywiser
Copy link
Copy Markdown
Member

wesleywiser commented Mar 12, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Mar 12, 2026

📌 Commit dbb9bbb has been approved by wesleywiser

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 12, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151194 - chenyukang:yukang-fix-150701-async…
cea42a6 
…-closure, r=wesleywiser

Fix wrong suggestion for returning async closure

Fixes rust-lang#150701

r? @estebank
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 12, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Mar 12, 2026
@bors
Auto merge of #153782 - JonathanBrouwer:rollup-p5MIIiQ, r=JonathanBro…
b5508ff 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #153751 (Detect existing turbofish on method calls to suppress useless suggestion)
 - #153780 (Remove `MTLock`)
 - #151194 (Fix wrong suggestion for returning async closure)
 - #151572 (Fix Hexagon ABI calling convention for small aggregates)
 - #153725 (Fix that `./x test --no-doc` actually keeps the same behaviour for backwards compatability)
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Mar 12, 2026

@bors r-
#153782 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Mar 12, 2026

This pull request was unapproved.

This PR was contained in a rollup (#153782), which was unapproved.

@fee1-dead fee1-dead mentioned this pull request Mar 18, 2026
Merged
@chenyukang chenyukang force-pushed the yukang-fix-150701-async-closure branch from dbb9bbb to a5bc8d4 Compare March 26, 2026 09:42
@rustbot

This comment has been minimized.

Sign in to view
@chenyukang
Copy link
Copy Markdown
Member Author

chenyukang commented Apr 19, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2026
@chenyukang chenyukang force-pushed the yukang-fix-150701-async-closure branch from a5bc8d4 to ae05a49 Compare April 19, 2026 04:41
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 19, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@chenyukang
Copy link
Copy Markdown
Member Author

chenyukang commented Apr 21, 2026

the ci failure is fixed by rebase to upstream.

@bors r=wesleywiser

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 21, 2026

📌 Commit ae05a49 has been approved by wesleywiser

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 21, 2026
@jhpratt
Rollup merge of rust-lang#151194 - chenyukang:yukang-fix-150701-async…
6e9a1c5 
…-closure, r=wesleywiser

Fix wrong suggestion for returning async closure

Fixes rust-lang#150701

r? @estebank
@jhpratt jhpratt mentioned this pull request Apr 21, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151194 - chenyukang:yukang-fix-150701-async…
55b415b 
…-closure, r=wesleywiser

Fix wrong suggestion for returning async closure

Fixes rust-lang#150701

r? @estebank
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 21, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 21, 2026
@jhpratt
Rollup merge of rust-lang#151194 - chenyukang:yukang-fix-150701-async…
3b5e423 
…-closure, r=wesleywiser

Fix wrong suggestion for returning async closure

Fixes rust-lang#150701

r? @estebank
This was referenced Apr 21, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 21, 2026
@bors
Auto merge of #155596 - jhpratt:rollup-zyXU16X, r=jhpratt
3655153 
Rollup of 6 pull requests

Successful merges:

 - #155028 (tests: add whitespace tests for vertical tab behavior)
 - #155582 (Rewrite `FlatMapInPlace`.)
 - #151194 (Fix wrong suggestion for returning async closure)
 - #154377 (Fix `#[expect(dead_code)]` liveness propagation)
 - #155572 (Move diagnostic attribute target checks from check_attr)
 - #155586 (Ensure we don't feed owners from ast lowering if we ever make that query tracked)
@rust-bors rust-bors Bot merged commit 545e7dc into rust-lang:main Apr 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@estebank estebank

Labels

A-async-closures `async || {}` A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

Additional suggestion for returning async closure Future is wrong

7 participants

@chenyukang @wesleywiser @JonathanBrouwer @rustbot @Kivooeo @estebank @SpriteOvO