Open
Conversation
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
95d3ff4 to
8b811db
Compare
8b811db to
236b137
Compare
alv-around
commented
Apr 24, 2026
Comment on lines
+66
to
+67
| ty::Uint(ty::UintTy::Usize) => Some(cx.tcx.data_layout.pointer_size().bits()), | ||
| ty::Uint(uint_ty) => uint_ty.bit_width(), |
Author
There was a problem hiding this comment.
this two lines could be replaced by the function int_ty_to_nbits util function. But the functions should be move from clippy_lints/src/casts/utils.rs to clippy_utils and I was unsure whether this is desired. I think that would be a good choice overall, as ty::Uint(uint_ty) => uint_ty.bitwidth(), return None for usize.
alv-around
commented
Apr 24, 2026
Comment on lines
+74
to
+75
| ty::Uint(ty::UintTy::Usize) => Some(cx.tcx.data_layout.pointer_size().bits()), | ||
| ty::Uint(uint_ty) => uint_ty.bit_width(), |
Author
There was a problem hiding this comment.
Same as in the previous comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16876
Current state:
T::BITS - x.leading_zeros()for uintsT::BITS - x.leading_zeros()for NonZeroDescription
rust 1.97 introduces the method
bit_width()for uints and NonZero (docs), this will make the manual computation redundant and unnecessary.Example
Can be replaced with:
changelog: [manual_bit_width]: Added a lint to detect bit_width implementations.
I have
.stderrfile)cargo testpasses locallycargo dev update_lintscargo dev fmt