Fix unnecessary_sort_by reverse suggestion using wrong closure parameter name#16868
Open
laffed wants to merge 1 commit intorust-lang:masterfrom
Open
Fix unnecessary_sort_by reverse suggestion using wrong closure parameter name#16868laffed wants to merge 1 commit intorust-lang:masterfrom
unnecessary_sort_by reverse suggestion using wrong closure parameter name#16868laffed wants to merge 1 commit intorust-lang:masterfrom
Conversation
…t suggestion When suggesting `sort_by_key` for a reversed comparator like `|a, b| b.foo.cmp(&a.foo)`, the lint was picking `left_expr` (the receiver of `.cmp()`, which references `b`) and `r_pat` as the closure arg, producing `|b| Reverse(b.foo)`. Both sides consistently named `b`, but `b` is the second parameter — confusing and inconsistent with the forward-sort suggestion style. Fix by using `right_expr` (the `.cmp()` argument, which references `a`) as the key body and `l_pat` as the closure parameter, peeling the single `&` that `.cmp(&rhs)` introduces so the suggestion doesn't contain a spurious borrow.
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When suggesting
sort_by_keyfor a reversed comparator like|a, b| b.foo.cmp(&a.foo), the lint was pickingleft_expr(the receiver of.cmp(), which referencesb) andr_patas the closure arg, producing|b| Reverse(b.foo). Both sides consistently namedb, butbis the second parameter — confusing and inconsistent with the forward-sort suggestion style.Fixed by using
right_expr(the.cmp()argument, which referencesa) as the key body andl_patas the closure parameter, peeling the single&that.cmp(&rhs)introduces so the suggestion doesn't contain a spurious borrow.changelog: [
unnecessary_sort_by]: fix reverse-sort suggestion using second closure parameter name (b) instead of first (a)