Skip to content

Update rust version#418

Merged
programmerjake merged 1 commit intomasterfrom
lock-rust-version
Apr 30, 2024
Merged

Update rust version#418
programmerjake merged 1 commit intomasterfrom
lock-rust-version

Conversation

@calebzulawski
Copy link
Copy Markdown
Member

@calebzulawski calebzulawski commented Apr 30, 2024

No description provided.

@calebzulawski calebzulawski changed the title Lock rust version Update rust version Apr 30, 2024
@calebzulawski
Copy link
Copy Markdown
Member Author

calebzulawski commented Apr 30, 2024

Whoops, we already had the toolchain locked. Thought I hadn't done it yet. Why did we suddenly get the inline_const stabilization errors? Maybe something wrong in the CI script

@programmerjake
Copy link
Copy Markdown
Member

programmerjake commented Apr 30, 2024

Whoops, we already had the toolchain locked. Thought I hadn't done it yet. Why did we suddenly get the inline_const stabilization errors? Maybe something wrong in the CI script

because inline consts were stabilized on nightly: rust-lang/rust#104087 (comment)

@programmerjake programmerjake merged commit 7cd6f95 into master Apr 30, 2024
@calebzulawski
Copy link
Copy Markdown
Member Author

calebzulawski commented Apr 30, 2024

I meant why was I seeing them when we were supposed to be locked to an older toolchain

@programmerjake
Copy link
Copy Markdown
Member

programmerjake commented Apr 30, 2024

I meant why was I seeing them when we were supposed to be locked to an older toolchain

the updated version uses today's (or yesterday depending on time zones) nightly...I wouldn't call that old. the stabilization PR was merged about a week ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@programmerjake programmerjake Awaiting requested review from programmerjake

@workingjubilee workingjubilee Awaiting requested review from workingjubilee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@calebzulawski @programmerjake