Skip to content

[ci] Update GitHub Actions to last major release#4981

Open
gruenich wants to merge 1 commit intorust-lang:masterfrom
gruenich:feature/update-github-actions
Open

[ci] Update GitHub Actions to last major release#4981
gruenich wants to merge 1 commit intorust-lang:masterfrom
gruenich:feature/update-github-actions

Conversation

@gruenich
Copy link
Copy Markdown

Fix deprecations warnings for Node20.js that will stop working in June.

Fix deprecations warnings for Node20.js that will stop working
in June.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 26, 2026

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Apr 26, 2026
Comment thread .github/workflows/ci.yml
run: cargo install -f rustup-toolchain-install-master
# Create a token for the next step so it can create a PR that actually runs CI.
- uses: actions/create-github-app-token@v2
- uses: actions/create-github-app-token@v3
Copy link
Copy Markdown
Member

@RalfJung RalfJung Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only one that's actually necessary? checkout v5 doesn't seem to emit any deprecation warnings.

View changes since the review

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. The other upadtes do not hurt, do they?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh so you just decided yourself that your answer is good enough and unilaterally marked the discussion as resolved?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, that was too fast, indeed.

@RalfJung
Copy link
Copy Markdown
Member

Thanks for the PR!

This GHA version silliness is getting seriously tiring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Waiting for a review to complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants