test: generate corrupt gzip fixture at runtime#550
Merged
Byron merged 1 commit intoJun 20, 2026
Conversation
|
Beat me to it on a travel day, thank you! |
Byron
approved these changes
Jun 20, 2026
| fn test_extract_failure() { | ||
| let result = extract_file(Path::new("tests/corrupt-gz-file.bin")); | ||
| let mut encoder = GzEncoder::new(Vec::new(), Compression::default()); | ||
| encoder.write_all(b"corrupt me").unwrap(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #549.
This removes
tests/corrupt-gz-file.binand updatestest_extract_failureto generate the corrupt gzip input in memory. The test now writes a small valid gzip stream withGzEncoder, flips a byte in the CRC32 portion of the gzip footer, then verifiesGzDecoderstill reportsio::ErrorKind::InvalidInput.That keeps the same failure-path coverage without shipping an opaque gzip-looking binary fixture that can trip security scanners.
Verification
cargo fmt --checkcargo test --test gunzipcargo test --test gunzip --features zlib-rs --no-default-featurescargo test --test gunzip --features zlib --no-default-features