Skip to content

extend archive index with lists, use in source view for tree#3314

Merged
syphar merged 3 commits intorust-lang:mainfrom
syphar:source-from-index
Apr 26, 2026
Merged

extend archive index with lists, use in source view for tree#3314
syphar merged 3 commits intorust-lang:mainfrom
syphar:source-from-index

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented Apr 26, 2026

  • right now we're storing a big JSON structure in releases.files, containing a list of all files in the source archive.
  • It's used to generate the file tree in our source handlers.
  • But: we already have the file list available in the archive index that belongs to the source archive, so we can use that and be much more efficient.

So this PR:

  • updates the storage lib to provide access to file lists in the index, and prefix filters
  • the source handlers now use the index, if archive storage is true.

Next steps after this:

  • perhaps stop storing the file list for new builds / releases
  • stop passing around the file-lists in results from storage, builders, ...
  • or, if repackaging is done, directly remove the column when we remove the legacy storage.

@syphar syphar requested a review from a team as a code owner April 26, 2026 22:01
@syphar syphar self-assigned this Apr 26, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 26, 2026
Comment thread crates/bin/docs_rs_web/src/utils/mod.rs Outdated
@syphar syphar requested a review from GuillaumeGomez April 26, 2026 22:19
@GuillaumeGomez
Copy link
Copy Markdown
Member

Looks good to me, thanks!

@syphar syphar merged commit ef4f404 into rust-lang:main Apr 26, 2026
14 of 15 checks passed
@syphar syphar deleted the source-from-index branch April 26, 2026 22:36
@github-actions github-actions Bot added the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Apr 26, 2026
@syphar syphar restored the source-from-index branch April 26, 2026 22:36
@github-actions github-actions Bot removed the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 26, 2026
@syphar syphar deleted the source-from-index branch April 26, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants