Skip to content

fix docker-compose / postgres setup for local & CI#3313

Merged
syphar merged 1 commit intorust-lang:mainfrom
syphar:fix-docker
Apr 26, 2026
Merged

fix docker-compose / postgres setup for local & CI#3313
syphar merged 1 commit intorust-lang:mainfrom
syphar:fix-docker

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented Apr 26, 2026

This should fix the compose errors in CI too.

error when running the db locally:

db-1  | Error: in 18+, these Docker images are configured to store database data in a
db-1  |        format which is compatible with "pg_ctlcluster" (specifically, using
db-1  |        major-version-specific directory names).  This better reflects how
db-1  |        PostgreSQL itself works, and how upgrades are to be performed.
db-1  |
db-1  |        See also https://github.com/docker-library/postgres/pull/1259
db-1  |
db-1  |        Counter to that, there appears to be PostgreSQL data in:
db-1  |          /var/lib/postgresql/data (unused mount/volume)
db-1  |
db-1  |        This is usually the result of upgrading the Docker image without
db-1  |        upgrading the underlying database using "pg_upgrade" (which requires both
db-1  |        versions).
db-1  |
db-1  |        The suggested container configuration for 18+ is to place a single mount
db-1  |        at /var/lib/postgresql which will then place PostgreSQL data in a
db-1  |        subdirectory, allowing usage of "pg_upgrade --link" without mount point
db-1  |        boundary issues.
db-1  |
db-1  |        See https://github.com/docker-library/postgres/issues/37 for a (long)
db-1  |        discussion around this process, and suggestions for how to do so.

@syphar syphar requested a review from a team as a code owner April 26, 2026 17:28
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 26, 2026
@syphar syphar self-assigned this Apr 26, 2026
@syphar syphar merged commit e9cfb22 into rust-lang:main Apr 26, 2026
14 checks passed
@syphar syphar deleted the fix-docker branch April 26, 2026 17:39
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants