Skip to content

block more encoded path traversals #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syphar merged 2 commits into from
Apr 14, 2026
Merged

block more encoded path traversals #3293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
844d814
block more encoded path traversals
syphar Apr 13, 2026
a4fdf90
also block `\\..` suffix in urls
syphar Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion crates/bin/docs_rs_web/src/middleware/security.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ fn validate_path(initial_path: &str) -> Result<()> {
}

fn validate_decoded_path(path: &str) -> Result<()> {
if path.contains("/../") || path.ends_with("/..") {
if path.contains("/../")
Comment thread
syphar marked this conversation as resolved.
|| path.ends_with("/..")
Comment thread
syphar marked this conversation as resolved.
|| path.contains("//\\../")
|| path.contains("\\..\\")
|| path.ends_with("\\..")
{
bail!("path traversal attempt");
}

Expand All @@ -61,6 +66,7 @@ mod tests {
testing::{AxumResponseTestExt as _, AxumRouterTestExt as _},
};
use axum::{Router, middleware, routing::get};

use test_case::test_case;
use tower::ServiceBuilder;

Expand All @@ -78,6 +84,18 @@ mod tests {
#[test_case(
"/crate/mika-cli/latest/source/..%25c1%259c..%25c1%259c..%25c1%259c..%25c1%259c..%25c1%259c..%25c1%259c..%25c1%259c..%25c1%259c/etc/passwd"
)]
#[test_case(
"/crate/aether/latest/source/compiler/node_modules/@richardanaya//%5c../%5c../%5c../%5c../%5c../%5c../%5c../etc/passwd";
"with backslash"
)]
#[test_case(
"/casual_logger/0.6.4/%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5cwindows/win.ini";
"double backslash"
)]
#[test_case(
"/casual_logger/0.6.4/%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e%5c%2e%2e";
"ends with backslash dot dot"
)]
async fn test_invalid_path(path: &str) -> Result<()> {
let app = Router::new()
.route("/{*inner}", get(|| async { StatusCode::OK }))
Expand Down
Loading