Allow tests to override the default closure impls#733
Open
JakobDegen wants to merge 1 commit intorust-lang:masterfrom
Open
Allow tests to override the default closure impls#733JakobDegen wants to merge 1 commit intorust-lang:masterfrom
JakobDegen wants to merge 1 commit intorust-lang:masterfrom
Conversation
In tests, closures can now explicitly specify `Fn*` impls, in which case the default impls will no longer be emitted. These types of impls are restricted to being non-generic over the type.
Contributor
|
☔ The latest upstream changes (presumably #753) made this pull request unmergeable. Please resolve the merge conflicts. |
| } | ||
| TyKind::Closure(closure_id, substitution) => { | ||
| for custom in db.custom_clauses() { | ||
| if let DomainGoal::LocalImplAllowed(tr) = |
Contributor
There was a problem hiding this comment.
Wait, why do we have to add this LocalImplAllowed? I'm fine with funky testing frameworks, but this seems to be a bit more invasive to the "lower layers" than I would like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In tests, closures can now have explicit
Fn*impls, in which case the default impls will no longer be emitted for that closure. These types of impls are restricted to being non-generic over the type. This allows reproducing #688 in a chalk test.The mechanism for this is an absolute hack; if there's any
impl Fn* for MyClosurethen the parser will generate a customLocalImplAllowedclause which is later searched for during WF checking of impls and before emitting default closure impls for that type. The upside of this is that we can re-use the plumbing on the chalk-solve side, especially the WF checking. This probably breaks coherence checking forFn*traits in tests, but that doesn't seem like an issue.