test: Add BusyBox ar compatibility test for issue #504#1634
Draft
naoNao89 wants to merge 2 commits intorust-lang:mainfrom
Draft
test: Add BusyBox ar compatibility test for issue #504#1634naoNao89 wants to merge 2 commits intorust-lang:mainfrom
naoNao89 wants to merge 2 commits intorust-lang:mainfrom
Conversation
naoNao89
force-pushed
the
fix/issue-504-busybox-ar-compatibility
branch
5 times, most recently
from
9aa36c4 to
0542f93
Compare
Fixes compilation failures when using BusyBox ar on Windows (and other platforms with non-GNU ar implementations). BusyBox's ar doesn't support the -s flag for symbol table generation. This change adds graceful fallback behavior: 1. Try ar s first (works with GNU ar and most implementations) 2. If ar s fails, fall back to ranlib (equivalent functionality) 3. If ranlib fails/unavailable, continue without symbol tables (acceptable as symbol tables are an optimization, not a requirement) Includes comprehensive cross-platform test coverage that verifies the fallback mechanism works correctly. Fixes rust-lang#504
naoNao89
force-pushed
the
fix/issue-504-busybox-ar-compatibility
branch
from
0542f93 to
6b66492
Compare
Add serial_test dependency and use #[serial] attribute to ensure the busybox_ar_fallback test runs serially, not in parallel with other tests. This prevents cross-contamination where the custom ar/ranlib scripts from this test interfere with other tests running concurrently in CI. Fixes CI failures where tests tried to write to directories belonging to other test instances.
naoNao89
force-pushed
the
fix/issue-504-busybox-ar-compatibility
branch
from
bddee93 to
7e0ad11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compilation failures when using BusyBox ar on Windows.
BusyBox's ar doesn't support the -s flag, so we now gracefully fall back to ranlib when ar s fails.
Includes comprehensive test coverage and backward compatible with GNU ar
Fixes #504