fix(compile): Where possible, hint about misplaced deps #16940
Open
epage wants to merge 10 commits intorust-lang:masterfrom
Open
fix(compile): Where possible, hint about misplaced deps #16940epage wants to merge 10 commits intorust-lang:masterfrom
epage wants to merge 10 commits intorust-lang:masterfrom
Conversation
The one side effect is we won't list used export in traces.
Through the re-ordering of things, the check has become redundant and can be removed.
Sometimes a normal dependency is actually a dev-dependency. For any of the dev-dependencies we build, we can let users know that an unused dep might be a misplaced dep.
rustbot
added
A-build-execution
Collaborator
|
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
The bump check is a non-blocking job currently broken by GitoxideLabs/gitoxide#2541 because cargo-semver-checks isn't able to respect lockfiles fully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Sometimes a normal dependency is actually a dev-dependency.
For any of the dev-dependencies we build, we can let users know that an
unused dep might be a misplaced dep. This check came from #8437 but I originally punted on it due to the complexity of having the right information. Through the refactors done in this, I found it became easy to report this. The help could be improved to show the insertion of the dev-dependency with a removal of the normal dependency but that is being left to a future exercise to limit the scope of this.
This also improves the quality of the logged messages for people who are ok with the false positives that we can't report.
How to test and review this PR?